Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | |
| 2 // User of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #ifndef CHROME_BROWSER_EXTENSIONS_ACTIVITY_ACTIONS_H_ | |
| 6 #define CHROME_BROWSER_EXTENSIONS_ACTIVITY_ACTIONS_H_ | |
| 7 | |
| 8 #include <string> | |
| 9 #include "base/values.h" | |
| 10 | |
| 11 namespace activity { | |
| 12 | |
| 13 // This is the interface for extension actions that are to be recorded in | |
| 14 // the activity log. | |
| 15 class Action { | |
| 16 public: | |
|
mvrable
2012/12/04 01:00:13
There's extra indentation here: the visibility spe
felt
2012/12/07 19:27:45
Done.
| |
| 17 // Print an action with il8n substitutions for display. | |
| 18 virtual std::string PrettyPrintForil8n() OVERRIDE; | |
|
mvrable
2012/12/04 01:00:13
OVERRIDE should be used in subclasses when overrid
felt
2012/12/07 19:27:45
Done.
| |
| 19 | |
| 20 // Print an action as a regular string for debugging purposes. | |
| 21 virtual std::string PrettyPrintForDebug() OVERRIDE; | |
| 22 | |
| 23 virtual ~Action(); | |
| 24 }; | |
| 25 } | |
|
mvrable
2012/12/04 01:00:13
Leave a blank line between the two closing braces,
felt
2012/12/07 19:27:45
Done.
| |
| 26 | |
| 27 #endif // CHROME_BROWSER_EXTENSIONS_ACTIVITY_ACTIONS_H_ | |
|
mvrable
2012/12/04 01:00:13
lint in the web interface complains about no newli
felt
2012/12/07 19:27:45
Done.
| |
| OLD | NEW |