Save extension activity log to a file.

chrome/browser/extensions/activity_actions.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// User of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_ACTIVITY_ACTIONS_H_
+#define CHROME_BROWSER_EXTENSIONS_ACTIVITY_ACTIONS_H_
+
+#include <string>
+#include "base/memory/ref_counted_memory.h"
+#include "base/values.h"
+
+namespace extensions {
+
+// This is the interface for extension actions that are to be recorded in
+// the activity log.
+class Action {
+ public:
+  // Print an action with il8n substitutions for display.
+  virtual std::string PrettyPrintFori18n() = 0;
+
+  // Print an action as a regular string for debugging purposes.
+  virtual std::string PrettyPrintForDebug() = 0;
+
+ protected:

[Eric Dingle, 2012/12/13 20:37:34]

You should also define a constructor, even if it does nothing. And in general,
the constructor and destructor can be defined as the first methods of the public
section. There's no need to make them protected/private unless you REALLY don't
want them being run from outside the class. This applies to all files in this
CL.

[felt, 2012/12/15 02:51:52]

They have to be protected/private due to the refcounting.

+  virtual ~Action() { }

[Eric Dingle, 2012/12/13 20:37:34]

Don't forget:

DISALLOW_COPY_AND_ASSIGN(Action);

[Eric Dingle, 2012/12/13 20:37:34]

I think the common style is to have no space between {} or to have the trailing
} on the next line. This applies to all files in this CL.

[felt, 2012/12/15 02:51:52]

Done.

[felt, 2012/12/15 02:51:52]

Done.

+};
+
+}  // namespace

[Eric Dingle, 2012/12/13 20:37:34]

// namespace extensions

This applies to all files in this CL.

[felt, 2012/12/15 02:51:52]

Done.

+
+#endif  // CHROME_BROWSER_EXTENSIONS_ACTIVITY_ACTIONS_H_
+

[Eric Dingle, 2012/12/13 20:37:34]

Remove extra line break. This applies to all files in this CL.

[felt, 2012/12/15 02:51:52]

Done.