Notify the ThemeService on extension install and not extension load

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 1016 matching lines @@
 
 void ExtensionService::NotifyExtensionLoaded(const Extension* extension) {
   // The ChromeURLRequestContexts need to be first to know that the extension
   // was loaded, otherwise a race can arise where a renderer that is created
   // for the extension may try to load an extension URL with an extension id
   // that the request context doesn't yet know about. The profile is responsible
   // for ensuring its URLRequestContexts appropriately discover the loaded
   // extension.
   system_->RegisterExtensionWithRequestContexts(extension);
 
-  if (extension->is_theme()) {
-#if defined(ENABLE_THEMES)
-    ThemeServiceFactory::SetThemeForProfile(profile_, extension);
-#endif
-  } else {
+  if (!extension->is_theme()) {
     // Tell renderers about non-theme extensions (renderers don't need
     // to know about themes).
     for (content::RenderProcessHost::iterator i(
             content::RenderProcessHost::AllHostsIterator());
          !i.IsAtEnd(); i.Advance()) {
       content::RenderProcessHost* host = i.GetCurrentValue();
       Profile* host_profile =
           Profile::FromBrowserContext(host->GetBrowserContext());
       if (host_profile->GetOriginalProfile() ==
           profile_->GetOriginalProfile()) {
@@ skipping 1055 matching lines @@
   // so we must ensure they have valid ordinals.
   if (extension->RequiresSortOrdinal()) {
     extension_prefs_->extension_sorting()->EnsureValidOrdinals(
         extension->id(), syncer::StringOrdinal());
   }
 
   extensions_.Insert(extension);
   SyncExtensionChangeIfNeeded(*extension);
   NotifyExtensionLoaded(extension);
   DoPostLoadTasks(extension);
+
+#if defined(ENABLE_THEMES)
+  if (extension->is_theme()) {
+    // Notify the ThemeService about the newly-installed theme.
+    ThemeServiceFactory::SetThemeForProfile(profile_, extension);
+  }
+#endif

[asargent_no_longer_on_chrome, 2012/12/01 00:54:56]

Perhaps this should go inside DoPostLoadTasks ?

[akalin, 2012/12/01 01:07:00]

Per our chat, looks like I shouldn't do this!

 }
 
 void ExtensionService::AddComponentExtension(const Extension* extension) {
   const std::string old_version_string(
       extension_prefs_->GetVersionString(extension->id()));
   const Version old_version(old_version_string);
 
   if (!old_version.IsValid() || !old_version.Equals(*extension->version())) {
     VLOG(1) << "Component extension " << extension->name() << " ("
         << extension->id() << ") installing/upgrading from '"
@@ skipping 902 matching lines @@
         extension_id, kOnUpdateAvailableEvent);
   } else {
     // Delay installation if the extension is not idle.
     return !IsExtensionIdle(extension_id);
   }
 }
 
 void ExtensionService::OnBlacklistUpdated() {
   CheckManagementPolicy();
 }