Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: build/android/run_tests.py

Issue 11421187: Raise an exception if a unittest target is missing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: raise an Exception instead Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/run_tests.py
diff --git a/build/android/run_tests.py b/build/android/run_tests.py
index 15186026629e4e22ca5d3bcd6defc79e2f061751..2818dfe07106f35802063e623e705a94741af3b1 100755
--- a/build/android/run_tests.py
+++ b/build/android/run_tests.py
@@ -113,11 +113,10 @@ def FullyQualifiedTestSuites(exe, option_test_suite, build_type):
for t in all_test_suites]
for t, q in zip(all_test_suites, qualified_test_suites):
if not os.path.exists(q):
- logging.critical('Test suite %s not found in %s.\n'
- 'Supported test suites:\n %s\n'
- 'Ensure it has been built.\n',
- t, q, _TEST_SUITES)
- return []
+ raise Exception('Test suite %s not found in %s.\n'
+ 'Supported test suites:\n %s\n'
+ 'Ensure it has been built.\n' %
+ (t, q, _TEST_SUITES))
return qualified_test_suites
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698