Issue 11421170: google_apis: Clean up base_operations.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11421170: google_apis: Clean up base_operations.h (Closed)

Created:
8 years ago by satorux1

Modified:
8 years ago

Reviewers:
kinaba

CC:
chromium-reviews, achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

google_apis: Clean up base_operations.h - Add and fix comments - Make some members private - Make some members const - Move GetResponseHeadersAsString() to anonymous namespace BUG=163544 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170419

Patch Set 1 : polish #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -51 lines)			Patch
	M	chrome/browser/google_apis/base_operations.h	View		7 chunks	+43 lines, -29 lines	0 comments	Download
	M	chrome/browser/google_apis/base_operations.cc	View		5 chunks	+24 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages