Add a tool to look for unused suppressions.

Add a tool to look for unused suppressions.

BUG=112065
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170387

[Alexander Potapenko, 2012-11-30 01:07:43]

Random thought: how about printing the suppression file names for the unused
suppressions so that one can easily find and delete them?

LGTM

[commit-bot: I haz the power, 2012-11-30 01:23:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/11421163/1

[commit-bot: I haz the power, 2012-11-30 03:45:13]

Change committed as 170387

[Paweł Hajdan Jr., 2012-11-30 16:48:02]

On 2012/11/30 01:07:43, Alexander Potapenko wrote:
> Random thought: how about printing the suppression file names for the unused
> suppressions so that one can easily find and delete them?

Sounds good to me. However, I'm not that much familiar with your workflow, so
would you mind if I just defer to you for tuning the output? The main part
(pulling data from c-b-l) is there.

[Alexander Potapenko, 2012-11-30 17:57:33]

Yes, someday.
We can see if people use this actively (I'm guessing they will) and then improve
the workflow basing on what they need.

Are you going to do something about the PYTHONPATH error?

[Timur Iskhodzhanov, 2012-12-03 11:14:13]

This prevents me from running presubmit checks while uploading a suppressions
change.

Alexander, have you observed anything like this?

https://chromiumcodereview.appspot.com/11421163/diff/1/tools/valgrind/suppres...
File tools/valgrind/suppressions.py (right):

https://chromiumcodereview.appspot.com/11421163/diff/1/tools/valgrind/suppres...
tools/valgrind/suppressions.py:32: import path_utils
Traceback (most recent call last):
  File "../depot_tools/gcl.py", line 1466, in <module>
    sys.exit(main(sys.argv[1:]))
  File "../depot_tools/gcl.py", line 1444, in main
    return command(argv[1:])
  File "../depot_tools/gcl.py", line 766, in hook
    return function(change_info, args)
  File "../depot_tools/gcl.py", line 818, in CMDupload
    output = OptionallyDoPresubmitChecks(change_info, False, args)
  File "../depot_tools/gcl.py", line 735, in OptionallyDoPresubmitChecks
    return DoPresubmitChecks(change_info, committing, True)
  File "../depot_tools/gcl.py", line 1227, in DoPresubmitChecks
    rietveld_obj=change_info.RpcServer())
  File ".../chromium/depot_tools/presubmit_support.py", line 1107, in
DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File ".../chromium/depot_tools/presubmit_support.py", line 1024, in
ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 27, in CheckChangeOnUpload
  File "<string>", line 20, in CheckChange
  File ".../chromium/src/tools/valgrind/tsan/../suppressions.py", line 32, in
<module>
    import path_utils
ImportError: No module named path_utils
Sending crash report ...
  args: ['../depot_tools/gcl.py', 'upload', 'glider', '--send_mail', '-r',
'glider@chromium.org']
  cwd: .../chromium/src/tools/valg
  exception: No module named path_utils
  host: ***.google.com
  stack:   File "../depot_tools/gcl.py", line 1466, in <mod
  user: timurrrr
  version: 2.6.5 (r265:79063, Oct  1 2012, 22:04:36) 
[GCC 4.
A stack trace has been sent to the maintainers.

[Timur Iskhodzhanov, 2012-12-03 11:19:19]

Fails on the trybots too, which is unacceptable.
https://chromium-status.appspot.com/cq/timurrrr@chromium.org/11419286/1

Reverting.

[Alexander Potapenko, 2012-12-06 20:13:41]

I saw this (https://chromiumcodereview.appspot.com/11412269/)
Something made me think Paweł was about to fix the problem, so I
didn't track it further, sorry.

On Mon, Dec 3, 2012 at 3:19 AM,  <timurrrr@chromium.org> wrote:
> Fails on the trybots too, which is unacceptable.
> https://chromium-status.appspot.com/cq/timurrrr@chromium.org/11419286/1
>
> Reverting.
>
> https://chromiumcodereview.appspot.com/11421163/



-- 
Alexander Potapenko
Software Engineer
Google Moscow