Issue 11421123: Fixed pointer arithmetic in write barrier for large objects when marking progress bar is used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11421123: Fixed pointer arithmetic in write barrier for large objects when marking progress bar is used. (Closed)

Created:
8 years ago by Hannes Payer (out of office)

Modified:
8 years ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fixed pointer arithmetic in write barrier for large objects when marking progress bar is used. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13073

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/spaces.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Michael Starzinger

8 years ago (2012-11-28 10:50:31 UTC) #2

LGTM. I should have seen this in the initial review. Pointer arithmetic is hard,
let's use a PointerArithmeticManagerFactory instead. :)