Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

Issue 11421111: Fixed button focusing in OOBE screens. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up the code. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Oobe user image screen implementation. 6 * @fileoverview Oobe user image screen implementation.
7 */ 7 */
8 8
9 cr.define('oobe', function() { 9 cr.define('oobe', function() {
10 var UserImagesGrid = options.UserImagesGrid; 10 var UserImagesGrid = options.UserImagesGrid;
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 }, 128 },
129 129
130 /** 130 /**
131 * Buttons in oobe wizard's button strip. 131 * Buttons in oobe wizard's button strip.
132 * @type {array} Array of Buttons. 132 * @type {array} Array of Buttons.
133 */ 133 */
134 get buttons() { 134 get buttons() {
135 var okButton = this.ownerDocument.createElement('button'); 135 var okButton = this.ownerDocument.createElement('button');
136 okButton.id = 'ok-button'; 136 okButton.id = 'ok-button';
137 okButton.textContent = localStrings.getString('okButtonText'); 137 okButton.textContent = localStrings.getString('okButtonText');
138 okButton.autofocus = true;
Nikita (slow) 2012/11/28 18:26:26 Not sure that we want to auto focus Ok button here
mtomasz 2012/11/28 21:57:42 Done.
138 okButton.addEventListener('click', this.acceptImage_.bind(this)); 139 okButton.addEventListener('click', this.acceptImage_.bind(this));
139 return [okButton]; 140 return [okButton];
140 }, 141 },
141 142
142 /** 143 /**
143 * The caption to use for the Profile image preview. 144 * The caption to use for the Profile image preview.
144 * @type {string} 145 * @type {string}
145 */ 146 */
146 get profileImageCaption() { 147 get profileImageCaption() {
147 return this.profileImageCaption_; 148 return this.profileImageCaption_;
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 ].forEach(function(name) { 346 ].forEach(function(name) {
346 UserImageScreen[name] = function(value) { 347 UserImageScreen[name] = function(value) {
347 $('user-image')[name + '_'](value); 348 $('user-image')[name + '_'](value);
348 }; 349 };
349 }); 350 });
350 351
351 return { 352 return {
352 UserImageScreen: UserImageScreen 353 UserImageScreen: UserImageScreen
353 }; 354 };
354 }); 355 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698