Fixed button focusing in OOBE screens.

chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('oobe', function() {
   /**
    * Creates a new oobe screen div.
    * @constructor
    * @extends {HTMLDivElement}
    */
@@ skipping 92 matching lines @@
      * Buttons in oobe wizard's button strip.
      * @type {array} Array of Buttons.
      */
     get buttons() {
       var buttons = [];
 
       var cancelButton = this.ownerDocument.createElement('button');
       cancelButton.id = 'oauth-enroll-cancel-button';
       cancelButton.textContent =
           localStrings.getString('oauthEnrollCancel');
+      cancelButton.autofocus = true;

[Nikita (slow), 2012/11/28 18:26:26]

Not sure that we would want to autofocus this button as focus is inside GAIA
sign in form that is shown on this screen.

[mtomasz, 2012/11/28 21:57:42]

Done. If we want it to be focused, then it will be done by showStep(). By the
way, can I somehow test this screen locally? It didn't work for me.

[Nikita (slow), 2012/11/29 16:08:11]

Did you try Ctrl+Alt+E shortcut.

You should launch Chrome in OOBE, go through first screens and when you're at
GAIA login, press Ctrl+Alt+E.
This shortcut also works on normal login screen with users for me.

[mtomasz, 2012/11/29 19:04:28]

I've tested and removed the change from this file since it was useless here.

       cancelButton.addEventListener('click', function(e) {
         chrome.send('oauthEnrollClose', ['cancel']);
       });
       buttons.push(cancelButton);
 
       var tryAgainButton = this.ownerDocument.createElement('button');
       tryAgainButton.id = 'oauth-enroll-try-again-button';
       tryAgainButton.hidden = true;
       tryAgainButton.textContent =
           localStrings.getString('oauthEnrollRetry');
@@ skipping 89 matching lines @@
      */
     showStep: function(step) {
       $('oauth-enroll-cancel-button').hidden = true;
       $('oauth-enroll-try-again-button').hidden = true;
       $('oauth-enroll-explain-button').hidden = true;
       $('oauth-enroll-done-button').hidden = true;
       for (var i = 0; i < this.steps_.length; i++) {
         var theStep = this.steps_[i];
         var active = (theStep.name == step);
         $('oauth-enroll-step-' + theStep.name).hidden = !active;
-        if (active && theStep.button) {
+        if (theStep.button) {
           var button = $('oauth-enroll-' + theStep.button + '-button');
-          button.hidden = false;
-          if (theStep.focusButton)
-            button.focus();
+          button.autofocus = false;
+          if (active) {
+            button.hidden = false;
+            if (theStep.focusButton) {
+              button.focus();
+              button.autofocus = true;
+            }
+          }
         }
       }
     },
 
     /**
      * Sets an error message and switches to the error screen.
      * @param {string} message the error message.
      * @param {boolean} retry whether the retry link should be shown.
      */
     showError: function(message, retry) {
@@ skipping 66 matching lines @@
       var msg = m.data;
       if (msg.method == 'completeLogin' && this.isSigninMessage_(m))
         chrome.send('oauthEnrollCompleteLogin', [msg.email, msg.password]);
     }
   };
 
   return {
     OAuthEnrollmentScreen: OAuthEnrollmentScreen
   };
 });