Issue 2429, core implementation and the protocol change

src/debug-debugger.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1288 matching lines @@
 
 
 ProtocolMessage.prototype.setOption = function(name, value) {
   if (!this.options_) {
     this.options_ = {};
   }
   this.options_[name] = value;
 };
 
 
-ProtocolMessage.prototype.failed = function(message) {
+ProtocolMessage.prototype.failed = function(message, opt_details) {
   this.success = false;
   this.message = message;
+  if (IS_OBJECT(opt_details)) {
+    this.error_details = opt_details;
+  }
 };
 
 
 ProtocolMessage.prototype.toJSONProtocol = function() {
   // Encode the protocol header.
   var json = {};
   json.seq= this.seq;
   if (this.request_seq) {
     json.request_seq = this.request_seq;
   }
@@ skipping 26 matching lines @@
       }
     } else {
       bodyJson = ObjectToProtocolObject_(this.body, serializer);
     }
     json.body = bodyJson;
     json.refs = serializer.serializeReferencedObjects();
   }
   if (this.message) {
     json.message = this.message;
   }
+  if (this.error_details) {
+    json.error_details = this.error_details;
+  }
   json.running = this.running;
   return JSON.stringify(json);
 };
 
 
 DebugCommandProcessor.prototype.createResponse = function(request) {
   return new ProtocolMessage(request);
 };
 
 
@@ skipping 1012 matching lines @@
   }
 
   var change_log = new Array();
 
   if (!IS_STRING(request.arguments.new_source)) {
     throw "new_source argument expected";
   }
 
   var new_source = request.arguments.new_source;
 
-  var result_description = Debug.LiveEdit.SetScriptSource(the_script,
-      new_source, preview_only, change_log);
+  var result_description;
+  try {
+    result_description = Debug.LiveEdit.SetScriptSource(the_script,
+        new_source, preview_only, change_log);
+  } catch (e) {
+    if (e instanceof Debug.LiveEdit.Failure && "details" in e) {
+      response.failed(e.message, e.details);
+      return;
+    }
+    throw e;
+  }
   response.body = {change_log: change_log, result: result_description};
 
   if (!preview_only && !this.running_ && result_description.stack_modified) {
     response.body.stepin_recommended = true;
   }
 };
 
 
 DebugCommandProcessor.prototype.restartFrameRequest_ = function(
     request, response) {
@@ skipping 254 matching lines @@
     case 'string':
     case 'number':
       json = value;
       break;
 
     default:
       json = null;
   }
   return json;
 }