Issue 2429, core implementation and the protocol change

src/liveedit.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 18 matching lines @@
 #include "v8.h"
 
 #include "liveedit.h"
 
 #include "code-stubs.h"
 #include "compilation-cache.h"
 #include "compiler.h"
 #include "debug.h"
 #include "deoptimizer.h"
 #include "global-handles.h"
+#include "messages.h"
 #include "parser.h"
 #include "scopeinfo.h"
 #include "scopes.h"
 #include "v8memory.h"
 
 namespace v8 {
 namespace internal {
 
 
 #ifdef ENABLE_DEBUGGER_SUPPORT
@@ skipping 869 matching lines @@
 
 
 JSArray* LiveEdit::GatherCompileInfo(Handle<Script> script,
                                      Handle<String> source) {
   Isolate* isolate = Isolate::Current();
 
   FunctionInfoListener listener;
   Handle<Object> original_source = Handle<Object>(script->source());
   script->set_source(*source);
   isolate->set_active_function_info_listener(&listener);
-  CompileScriptForTracker(isolate, script);
+
+  {
+    // Creating verbose TryCatch from public API is currently the only way to
+    // force code save location. We do not use this the object directly.
+    v8::TryCatch try_catch;
+    try_catch.SetVerbose(true);
+
+    // A logical 'try' section.
+    CompileScriptForTracker(isolate, script);
+  }
+
+  // A logical 'catch' section.
+  Handle<Object> rethrow_exception;
+  if (isolate->has_pending_exception()) {
+    Handle<Object> exception(isolate->pending_exception()->ToObjectChecked());
+    MessageLocation message_location = isolate->GetMessageLocation();
+
+    isolate->clear_pending_message();
+    isolate->clear_pending_exception();
+
+    // If possible, copy positions from message object to exception object.
+    if (exception->IsJSObject() && !message_location.script().is_null()) {
+      Handle<JSObject> exception_struct = Handle<JSObject>::cast(exception);
+
+      Factory* factory = isolate->factory();
+      JSReceiver::SetProperty(exception_struct,
+          factory->LookupAsciiSymbol("startPosition"),

[Michael Starzinger, 2012/12/04 09:51:05]

This pattern is not GC safe. Other handles might have been dereferenced before
the call to LookupAsciiSymbol, which in turn can cause a GC. The factory call
needs to be done separately before a sequence point.

+          Handle<Smi>(Smi::FromInt(message_location.start_pos())),
+          NONE, kNonStrictMode);
+      JSReceiver::SetProperty(exception_struct,
+          factory->LookupAsciiSymbol("endPosition"),

[Michael Starzinger, 2012/12/04 09:51:05]

Likewise.

+          Handle<Smi>(Smi::FromInt(message_location.end_pos())),
+          NONE, kNonStrictMode);
+      JSReceiver::SetProperty(exception_struct,
+          factory->LookupAsciiSymbol("scriptObject"),

[Michael Starzinger, 2012/12/04 09:51:05]

Likewise.

+          GetScriptWrapper(message_location.script()),
+          NONE, kNonStrictMode);
+    }
+
+    rethrow_exception = exception;
+  }
+
+  // A logical 'finally' section.
   isolate->set_active_function_info_listener(NULL);
   script->set_source(*original_source);
 
-  return *(listener.GetResult());
+  if (rethrow_exception.is_null()) {
+    return *(listener.GetResult());
+  } else {
+    isolate->Throw(*rethrow_exception);
+    return 0;
+  }
 }
 
 
 void LiveEdit::WrapSharedFunctionInfos(Handle<JSArray> array) {
   HandleScope scope;
   int len = GetArrayLength(array);
   for (int i = 0; i < len; i++) {
     Handle<SharedFunctionInfo> info(
         SharedFunctionInfo::cast(array->GetElementNoExceptionThrown(i)));
     SharedInfoWrapper info_wrapper = SharedInfoWrapper::Create();
@@ skipping 1113 matching lines @@
 
 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
   return false;
 }
 
 #endif  // ENABLE_DEBUGGER_SUPPORT
 
 
 
 } }  // namespace v8::internal