Issue 2429, core implementation and the protocol change

src/liveedit-debugger.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 58 matching lines @@
     MarkChangedFunctions(root_old_node, pos_translator.GetChunks());
 
     // Find all SharedFunctionInfo's that were compiled from this script.
     FindLiveSharedInfos(root_old_node, script);
 
     // Gather compile information about new version of script.
     var new_compile_info;
     try {
       new_compile_info = GatherCompileInfo(new_source, script);
     } catch (e) {
-      throw new Failure("Failed to compile new version of script: " + e);
+      var failure =
+          new Failure("Failed to compile new version of script: " + e);
+      if (e instanceof SyntaxError) {
+        var details = {
+          type: "liveedit_compile_error",
+          syntaxErrorMessage: e.message
+        };
+        failure.details = details;

[Yang, 2012/11/28 15:51:28]

I'd put this after the following if, even though this doesn't really make a
difference.

[Yang, 2012/11/29 16:38:57]

I still think this would make sense.

[Peter Rybin, 2012/11/29 23:16:05]

You mean this only line?
Done

+        if ("startPosition" in e) {
+          var position_struct = {
+            startPosition: e.startPosition,
+            endPosition: e.endPosition,
+            startLine: e.startLine,
+            startColumn: e.startColumn,
+            endColumn: e.endColumn
+          };
+          details.position = position_struct; 
+        }
+      }
+      throw failure; 
     }
     var root_new_node = BuildCodeInfoTree(new_compile_info);
 
     // Link recompiled script data with other data.
     FindCorrespondingFunctions(root_old_node, root_new_node);
 
     // Prepare to-do lists.
     var replace_code_list = new Array();
     var link_to_old_script_list = new Array();
     var link_to_original_script_list = new Array();
@@ skipping 1003 matching lines @@
   // Function is public.
   this.RestartFrame = RestartFrame;
 
   // Functions are public for tests.
   this.TestApi = {
     PosTranslator: PosTranslator,
     CompareStrings: CompareStrings,
     ApplySingleChunkPatch: ApplySingleChunkPatch
   };
 };