sdk/lib/_internal/compiler/implementation/ssa/codegen.dart - Issue 11421056: Re-apply issue 11308169: GVN getInterceptor and use the interceptor constant when the type is known.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 11421056: Re-apply issue 11308169: GVN getInterceptor and use the interceptor constant when the type is known. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/interceptors.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (revision 15379)

+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (working copy)

@@ -1559,18 +1559,12 @@

arguments = visitArguments(node.inputs);

bool inLoop = node.block.enclosingLoopHeader != null;

- // Register this invocation to collect the types used at all call sites.

Selector selector = getOptimizedSelectorFor(node, node.selector);

- // TODO(ngeoffray): Remove the following restriction. Because

- // the second input of this interceptor call is the actual

- // receiver (the first is the interceptor), the backend gets

- // confused. We should pass a list of types instead of a node to

- // [registerDynamicInvocation].

- if (!node.isInterceptorCall) {

- backend.registerDynamicInvocation(node, selector, types);

- } else {

+ if (node.isInterceptorCall) {

backend.addInterceptedSelector(selector);

}

+ // Register this invocation to collect the types used at all call sites.

+ backend.registerDynamicInvocation(node, selector, types);

// If we don't know what we're calling or if we are calling a getter,

// we need to register that fact that we may be calling a closure