ash/accelerators/accelerator_table.cc - Issue 11421055: Add power-user keyboard mode for ChromeOS with Search key acting as a typical Fn key.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/accelerators/accelerator_table.cc

Issue 11421055: Add power-user keyboard mode for ChromeOS with Search key acting as a typical Fn key. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: SkyNits Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/accelerators/accelerator_table.cc

diff --git a/ash/accelerators/accelerator_table.cc b/ash/accelerators/accelerator_table.cc

index 57ba21791c865c289c6fbf07a79c23c72bf48742..caed475765d543a2b27691a3b340bf4307084d04 100644

--- a/ash/accelerators/accelerator_table.cc

+++ b/ash/accelerators/accelerator_table.cc

@@ -108,8 +108,11 @@ const AcceleratorData kAcceleratorData[] = {

CYCLE_BACKWARD_LINEAR },

{ true, ui::VKEY_T, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, RESTORE_TAB },

{ true, ui::VKEY_PRINT, ui::EF_NONE, TAKE_SCREENSHOT },

- // On Chrome OS, Search key is mapped to LWIN.

+ // On Chrome OS, Search key is mapped to LWIN. The Search key binding should

+ // act on release instead of press when using Search as a modifier key for

+ // extended keyboard shortcuts.

{ true, ui::VKEY_LWIN, ui::EF_NONE, TOGGLE_APP_LIST },

+ { false, ui::VKEY_LWIN, ui::EF_NONE, TOGGLE_APP_LIST },

{ true, ui::VKEY_MEDIA_LAUNCH_APP2, ui::EF_NONE, TOGGLE_APP_LIST },

{ true, ui::VKEY_LWIN, ui::EF_ALT_DOWN, TOGGLE_CAPS_LOCK },

{ true, ui::VKEY_VOLUME_MUTE, ui::EF_NONE, VOLUME_MUTE },

« no previous file with comments | « ash/accelerators/accelerator_controller_unittest.cc ('k') | ash/shell/shell_delegate_impl.h » ('j') | no next file with comments »