Index: ash/accelerators/accelerator_table.cc |
diff --git a/ash/accelerators/accelerator_table.cc b/ash/accelerators/accelerator_table.cc |
index 57ba21791c865c289c6fbf07a79c23c72bf48742..059e76c88530aa07e4b144bc64bcc8ce0fbaad2a 100644 |
--- a/ash/accelerators/accelerator_table.cc |
+++ b/ash/accelerators/accelerator_table.cc |
@@ -108,10 +108,12 @@ const AcceleratorData kAcceleratorData[] = { |
CYCLE_BACKWARD_LINEAR }, |
{ true, ui::VKEY_T, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, RESTORE_TAB }, |
{ true, ui::VKEY_PRINT, ui::EF_NONE, TAKE_SCREENSHOT }, |
- // On Chrome OS, Search key is mapped to LWIN. |
- { true, ui::VKEY_LWIN, ui::EF_NONE, TOGGLE_APP_LIST }, |
+ // On Chrome OS, Search key is mapped to LWIN. Search key bindings should act |
+ // on release instead of press, since the press can be eaten when using Search |
+ // as a modifier key for extended keyboard shortcuts. |
+ { false, ui::VKEY_LWIN, ui::EF_NONE, TOGGLE_APP_LIST }, |
Yusuke Sato
2012/11/26 06:09:38
Could you keep the accelerator to be triggered on
danakj
2012/11/26 17:20:16
If we keep it on press, then when the feature is e
Yusuke Sato
2012/11/26 21:15:05
Oh now I understood what you wanted to do. Thanks
|
{ true, ui::VKEY_MEDIA_LAUNCH_APP2, ui::EF_NONE, TOGGLE_APP_LIST }, |
- { true, ui::VKEY_LWIN, ui::EF_ALT_DOWN, TOGGLE_CAPS_LOCK }, |
+ { false, ui::VKEY_LWIN, ui::EF_ALT_DOWN, TOGGLE_CAPS_LOCK }, |
Yusuke Sato
2012/11/26 06:09:38
I guess TOGGLE_CAPS_LOCK is not fired if the user
danakj
2012/11/26 17:20:16
I can make it not rewrite the Search press when an
danakj
2012/11/26 19:36:26
Done.
|
{ true, ui::VKEY_VOLUME_MUTE, ui::EF_NONE, VOLUME_MUTE }, |
{ true, ui::VKEY_VOLUME_DOWN, ui::EF_NONE, VOLUME_DOWN }, |
{ true, ui::VKEY_VOLUME_UP, ui::EF_NONE, VOLUME_UP }, |