Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2775)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ash/accelerators/accelerator_table.cc

Issue 11421055: Add power-user keyboard mode for ChromeOS with Search key acting as a typical Fn key. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/accelerators/accelerator_controller_unittest.cc ('k') | chrome/app/chromeos_strings.grdp » ('j') | chrome/app/chromeos_strings.grdp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/accelerators/accelerator_table.cc
diff --git a/ash/accelerators/accelerator_table.cc b/ash/accelerators/accelerator_table.cc
index 57ba21791c865c289c6fbf07a79c23c72bf48742..88d59dc6da5d02e459b39dffd7a2e5878b7fdb11 100644
--- a/ash/accelerators/accelerator_table.cc
+++ b/ash/accelerators/accelerator_table.cc
@@ -108,8 +108,10 @@ const AcceleratorData kAcceleratorData[] = {
CYCLE_BACKWARD_LINEAR },
{ true, ui::VKEY_T, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, RESTORE_TAB },
{ true, ui::VKEY_PRINT, ui::EF_NONE, TAKE_SCREENSHOT },
- // On Chrome OS, Search key is mapped to LWIN.
- { true, ui::VKEY_LWIN, ui::EF_NONE, TOGGLE_APP_LIST },
+ // On Chrome OS, Search key is mapped to LWIN. The Search key binding should
+ // act on release instead of press, since the press can be eaten when using
+ // Search as a modifier key for extended keyboard shortcuts.
+ { false, ui::VKEY_LWIN, ui::EF_NONE, TOGGLE_APP_LIST },
{ true, ui::VKEY_MEDIA_LAUNCH_APP2, ui::EF_NONE, TOGGLE_APP_LIST },
{ true, ui::VKEY_LWIN, ui::EF_ALT_DOWN, TOGGLE_CAPS_LOCK },
{ true, ui::VKEY_VOLUME_MUTE, ui::EF_NONE, VOLUME_MUTE },
« no previous file with comments | « ash/accelerators/accelerator_controller_unittest.cc ('k') | chrome/app/chromeos_strings.grdp » ('j') | chrome/app/chromeos_strings.grdp » ('J')

Powered by Google App Engine
This is Rietveld 408576698