Add power-user keyboard mode for ChromeOS with Search key acting as a typical Fn key.

ash/accelerators/accelerator_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_controller.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 
@@ skipping 433 matching lines @@
 
   // Ignore accelerators invoked as repeated (while holding a key for a long
   // time, if their handling is nonrepeatable.
   if (nonrepeatable_actions_.find(action) != nonrepeatable_actions_.end() &&
       context_.repeated() && !gesture_event) {
     return true;
   }
   // Type of the previous accelerator. Used by NEXT_IME and DISABLE_CAPS_LOCK.
   const ui::EventType previous_event_type =
     context_.previous_accelerator().type();
+  const ui::KeyboardCode previous_key_code =

[sky, 2012/11/27 02:01:53]

nit: since you only need this in TOGGLE_APP_LIST, move it there.

[danakj, 2012/11/27 02:27:18]

Done.

+    context_.previous_accelerator().key_code();
 
   // You *MUST* return true when some action is performed. Otherwise, this
   // function might be called *twice*, via BrowserView::PreHandleKeyboardEvent
   // and BrowserView::HandleKeyboardEvent, for a single accelerator press.
   switch (action) {
     case CYCLE_BACKWARD_MRU:
       if (key_code == ui::VKEY_TAB && shell->delegate())
         shell->delegate()->RecordUserMetricsAction(UMA_ACCEL_PREVWINDOW_TAB);
       return HandleCycleWindowMRU(WindowCycleController::BACKWARD,
                                   accelerator.IsAltDown());
@@ skipping 63 matching lines @@
       return true;
     case TAKE_PARTIAL_SCREENSHOT:
       if (screenshot_delegate_.get()) {
         ash::PartialScreenshotView::StartPartialScreenshot(
             screenshot_delegate_.get());
       }
       // Return true to prevent propagation of the key event because
       // this key combination is reserved for partial screenshot.
       return true;
     case TOGGLE_APP_LIST:
+      if (accelerator.key_code() == ui::VKEY_LWIN) {
+        // For bindings on the Search key, activate the binding on press if the
+        // Search key is not acting as a modifier. Otherwise, activate it on
+        // release.
+
+        bool search_as_function_key =

[sky, 2012/11/27 02:01:53]

nit: if you're doing to use const like you did on 454 be consistent and use it
here too.

[danakj, 2012/11/27 02:27:18]

Done.

+            Shell::GetInstance()->delegate()->IsSearchKeyActingAsFunctionKey();
+        bool type_pressed = accelerator.type() == ui::ET_KEY_PRESSED;
+
+        if (!search_as_function_key && !type_pressed)
+          return false;
+        if (search_as_function_key && type_pressed)
+          return false;
+        if (search_as_function_key &&
+            // If something else was pressed between the Search key (LWIN)
+            // being pressed and released, then ignore the release of the
+            // Search key.
+            (previous_event_type == ui::ET_KEY_RELEASED ||
+             previous_key_code != ui::VKEY_LWIN)) {
+          return false;
+        }
+      }
       if (key_code == ui::VKEY_LWIN && shell->delegate())
         shell->delegate()->RecordUserMetricsAction(UMA_ACCEL_SEARCH_LWIN);
       // When spoken feedback is enabled, we should neither toggle the list nor
       // consume the key since Search+Shift is one of the shortcuts the a11y
       // feature uses. crbug.com/132296
       DCHECK_EQ(ui::VKEY_LWIN, accelerator.key_code());
       if (Shell::GetInstance()->delegate()->IsSpokenFeedbackEnabled())
         return false;
       ash::Shell::GetInstance()->ToggleAppList();
       return true;
@@ skipping 322 matching lines @@
     keyboard_brightness_control_delegate) {
   keyboard_brightness_control_delegate_ =
       keyboard_brightness_control_delegate.Pass();
 }
 
 bool AcceleratorController::CanHandleAccelerators() const {
   return true;
 }
 
 }  // namespace ash