Remove FaviconUtil::DownloadFavicon

Remove FaviconUtil::DownloadFavicon

BUG=160995
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169884

[Cait (Slow), 2012-11-22 19:40:39]

Hi Steven,

This CL removes the static DownloadFavicon method from FaviconUtil, as it is no
longer in use. PTAL.

Thanks!

[stevenjb, 2012-11-26 18:21:58]

lgtm w/ nit

https://codereview.chromium.org/11421051/diff/2001/chrome/browser/favicon/fav...
File chrome/browser/favicon/favicon_download_helper.cc (right):

https://codereview.chromium.org/11421051/diff/2001/chrome/browser/favicon/fav...
chrome/browser/favicon/favicon_download_helper.cc:17: } // namespace.
nit: extra space before // (or omit comment for short anon namespace)
Also, I think that a function static is probably preferable here.

[Cait (Slow), 2012-11-26 23:37:19]

https://codereview.chromium.org/11421051/diff/2001/chrome/browser/favicon/fav...
File chrome/browser/favicon/favicon_download_helper.cc (right):

https://codereview.chromium.org/11421051/diff/2001/chrome/browser/favicon/fav...
chrome/browser/favicon/favicon_download_helper.cc:17: } // namespace.
On 2012/11/26 18:21:58, stevenjb (chromium) wrote:
> nit: extra space before // (or omit comment for short anon namespace)
> Also, I think that a function static is probably preferable here.

Done.

[commit-bot: I haz the power, 2012-11-26 23:42:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/11421051/3005

[commit-bot: I haz the power, 2012-11-27 03:08:52]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-11-28 00:52:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/11421051/4002

[commit-bot: I haz the power, 2012-11-28 02:09:10]

Retried try job too often for step(s) aura_unit_tests, browser_tests,
view_unittests

[commit-bot: I haz the power, 2012-11-28 02:36:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/11421051/4002

[commit-bot: I haz the power, 2012-11-28 09:05:56]

Change committed as 169884