tests/presubmit_unittest.py - Issue 11421050: Add presubmit check for dcommitted / CQed CLs - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(154)

My Issues | Starred Open | Closed | All

Unified Diff: tests/presubmit_unittest.py

Issue 11421050: Add presubmit check for dcommitted / CQed CLs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« presubmit_canned_checks.py ('K') | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/presubmit_unittest.py

diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py

index cf449dcc83fe0569926c41c6e786233c06cf901d..0c4b87f152e9583ba4df2badff64c23f02989f5d 100755

--- a/tests/presubmit_unittest.py

+++ b/tests/presubmit_unittest.py

@@ -1491,6 +1491,7 @@ class CannedChecksUnittest(PresubmitTestsBase):

def testMembersChanged(self):

self.mox.ReplayAll()

members = [

+ 're',

'CheckBuildbotPendingBuilds',

'CheckChangeHasBugField', 'CheckChangeHasDescription',

'CheckChangeHasNoStrayWhitespace',

@@ -1504,6 +1505,7 @@ class CannedChecksUnittest(PresubmitTestsBase):

'CheckChangeWasUploaded',

'CheckDoNotSubmit',

'CheckDoNotSubmitInDescription', 'CheckDoNotSubmitInFiles',

+ 'CheckChangeDescriptionNotCommitted',

'CheckLongLines', 'CheckTreeIsOpen', 'PanProjectChecks',

'CheckLicense',

'CheckOwners',

« presubmit_canned_checks.py ('K') | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698