Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 11421047: sync: Move data_encryption_win.h into syncer namespace. (Closed)

Created:
8 years, 1 month ago by tfarina
Modified:
8 years ago
Reviewers:
akalin, dhollowa
CC:
chromium-reviews, akalin, Raghu Simha, tfarina, dhollowa+watch_chromium.org, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, dyu1, estade+watch_chromium.org, Albert Bodenhamer, haitaol1, Ilya Sherman, tim (not reviewing), dhollowa
Visibility:
Public.

Description

sync: Move data_encryption_win.h into syncer namespace. R=akalin@chromium.org TBR=dhollowa@chromium.org # for autofill Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169392

Patch Set 1 : #

Patch Set 2 : fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -27 lines) Patch
M chrome/browser/autofill/autofill_ie_toolbar_import_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_ie_toolbar_import_win_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sync/util/data_encryption_win.h View 1 chunk +5 lines, -4 lines 0 comments Download
M sync/util/data_encryption_win.cc View 5 chunks +7 lines, -10 lines 0 comments Download
M sync/util/data_encryption_win_unittest.cc View 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
Hi Fred, could you review this to me? Thanks,
8 years, 1 month ago (2012-11-22 00:24:55 UTC) #1
akalin
lgtm
8 years, 1 month ago (2012-11-22 02:47:43 UTC) #2
tfarina
TBRing David...
8 years ago (2012-11-24 23:35:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11421047/5001
8 years ago (2012-11-24 23:36:01 UTC) #4
commit-bot: I haz the power
Change committed as 169392
8 years ago (2012-11-25 04:28:45 UTC) #5
dhollowa
8 years ago (2012-11-27 18:47:26 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698