Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5207)

Unified Diff: chrome/browser/notifications/notification_ui_manager_impl.cc

Issue 11421029: Remove PrefObserver usages, batch 13. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix - rebase Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_ui_manager_impl.cc
diff --git a/chrome/browser/notifications/notification_ui_manager_impl.cc b/chrome/browser/notifications/notification_ui_manager_impl.cc
index 21b4b011cd86cbccd2036914aef559d92ff7d615..5c19f040d9c53f8a47f5beba8f26c8ab37543c62 100644
--- a/chrome/browser/notifications/notification_ui_manager_impl.cc
+++ b/chrome/browser/notifications/notification_ui_manager_impl.cc
@@ -51,7 +51,12 @@ NotificationUIManagerImpl::NotificationUIManagerImpl(PrefService* local_state)
is_user_active_(true) {
registrar_.Add(this, chrome::NOTIFICATION_APP_TERMINATING,
content::NotificationService::AllSources());
- position_pref_.Init(prefs::kDesktopNotificationPosition, local_state, this);
+ position_pref_.Init(
+ prefs::kDesktopNotificationPosition,
+ local_state,
+ base::Bind(
+ &NotificationUIManagerImpl::OnDesktopNotificationPositionChanged,
+ base::Unretained(this)));
#if defined(OS_MACOSX)
InitFullScreenMonitor();
InitIdleMonitor();
@@ -240,12 +245,8 @@ void NotificationUIManagerImpl::Observe(
}
}
-void NotificationUIManagerImpl::OnPreferenceChanged(
- PrefServiceBase* service,
- const std::string& pref_name) {
- if (pref_name == prefs::kDesktopNotificationPosition) {
- balloon_collection_->SetPositionPreference(
- static_cast<BalloonCollection::PositionPreference>(
- position_pref_.GetValue()));
- }
+void NotificationUIManagerImpl::OnDesktopNotificationPositionChanged() {
+ balloon_collection_->SetPositionPreference(
+ static_cast<BalloonCollection::PositionPreference>(
+ position_pref_.GetValue()));
}
« no previous file with comments | « chrome/browser/notifications/notification_ui_manager_impl.h ('k') | chrome/browser/ui/views/location_bar/location_bar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698