Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: ash/accelerators/nested_dispatcher_controller_unittest.cc

Issue 11421006: Desktop aura: Break aura::Window::SetParent in two. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: I think the content_unittests timeout on linux_aura is flake, but try to fix it anyway. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/accelerators/nested_dispatcher_controller_unittest.cc
diff --git a/ash/accelerators/nested_dispatcher_controller_unittest.cc b/ash/accelerators/nested_dispatcher_controller_unittest.cc
index 74ea2e8bb8c9579f3c3bce63f95f837ae2030d11..4e42d6bb7cd6cbfff1c8ab3ccfc8bce7fce80e39 100644
--- a/ash/accelerators/nested_dispatcher_controller_unittest.cc
+++ b/ash/accelerators/nested_dispatcher_controller_unittest.cc
@@ -107,8 +107,7 @@ typedef AshTestBase NestedDispatcherTest;
// Aura window below lock screen in z order.
TEST_F(NestedDispatcherTest, AssociatedWindowBelowLockScreen) {
MockDispatcher inner_dispatcher;
- scoped_ptr<aura::Window> associated_window(aura::test::CreateTestWindowWithId(
- 0, NULL));
+ scoped_ptr<aura::Window> associated_window(CreateTestWindowInShellWithId(0));
Shell::GetInstance()->delegate()->LockScreen();
DispatchKeyReleaseA();
@@ -126,10 +125,9 @@ TEST_F(NestedDispatcherTest, AssociatedWindowAboveLockScreen) {
MockDispatcher inner_dispatcher;
scoped_ptr<aura::Window>mock_lock_container(
- aura::test::CreateTestWindowWithId(0, NULL));
+ CreateTestWindowInShellWithId(0));
aura::test::CreateTestWindowWithId(0, mock_lock_container.get());
- scoped_ptr<aura::Window>associated_window(aura::test::CreateTestWindowWithId(
- 0, NULL));
+ scoped_ptr<aura::Window> associated_window(CreateTestWindowInShellWithId(0));
EXPECT_TRUE(aura::test::WindowIsAbove(associated_window.get(),
mock_lock_container.get()));

Powered by Google App Engine
This is Rietveld 408576698