content/browser/web_contents/web_contents_view_aura.cc - Issue 11421006: Desktop aura: Break aura::Window::SetParent in two.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 11421006: Desktop aura: Break aura::Window::SetParent in two. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-add parent finding thing to web_contents_view_aura.cc. I guess it was necessary after all? Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_view_aura.cc

diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc

index 63d1fe94eee433f323faefc664fe0309475f7717..ff53e847fc877c1277d8118bcb544b2238a9d852 100644

--- a/content/browser/web_contents/web_contents_view_aura.cc

+++ b/content/browser/web_contents/web_contents_view_aura.cc

@@ -499,7 +499,8 @@ void WebContentsViewAura::CreateView(const gfx::Size& initial_size) {

window_->SetType(aura::client::WINDOW_TYPE_CONTROL);

window_->SetTransparent(false);

window_->Init(ui::LAYER_NOT_DRAWN);

- window_->SetParent(NULL);

+ // TODO(erg): Do something else here later.

+ window_->SetDefaultParentByTargetRoot(NULL);

window_->layer()->SetMasksToBounds(true);

window_->SetName("WebContentsViewAura");