ash/wm/workspace/workspace_window_resizer_unittest.cc - Issue 11421006: Desktop aura: Break aura::Window::SetParent in two.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/workspace_window_resizer_unittest.cc

Issue 11421006: Desktop aura: Break aura::Window::SetParent in two. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-add parent finding thing to web_contents_view_aura.cc. I guess it was necessary after all? Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/workspace/workspace_window_resizer_unittest.cc

diff --git a/ash/wm/workspace/workspace_window_resizer_unittest.cc b/ash/wm/workspace/workspace_window_resizer_unittest.cc

index 47b3c08f282a2bcf830b20a530e83102a4f5b014..f54b8d67a4559974fc17a17958967ff2e6026c43 100644

--- a/ash/wm/workspace/workspace_window_resizer_unittest.cc

+++ b/ash/wm/workspace/workspace_window_resizer_unittest.cc

@@ -74,19 +74,19 @@ class WorkspaceWindowResizerTest : public test::AshTestBase {

window_.reset(new aura::Window(&delegate_));

window_->SetType(aura::client::WINDOW_TYPE_NORMAL);

window_->Init(ui::LAYER_NOT_DRAWN);

- window_->SetParent(NULL);

+ AddToRootWindow(window_.get());

window_->set_id(1);

window2_.reset(new aura::Window(&delegate2_));

window2_->SetType(aura::client::WINDOW_TYPE_NORMAL);

window2_->Init(ui::LAYER_NOT_DRAWN);

- window2_->SetParent(NULL);

+ AddToRootWindow(window2_.get());

window2_->set_id(2);

window3_.reset(new aura::Window(&delegate3_));

window3_->SetType(aura::client::WINDOW_TYPE_NORMAL);

window3_->Init(ui::LAYER_NOT_DRAWN);

- window3_->SetParent(NULL);

+ AddToRootWindow(window3_.get());

window3_->set_id(3);

}