ash/wm/workspace/workspace_event_handler_unittest.cc - Issue 11421006: Desktop aura: Break aura::Window::SetParent in two.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/workspace_event_handler_unittest.cc

Issue 11421006: Desktop aura: Break aura::Window::SetParent in two. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-add parent finding thing to web_contents_view_aura.cc. I guess it was necessary after all? Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/workspace/workspace_event_handler_unittest.cc

diff --git a/ash/wm/workspace/workspace_event_handler_unittest.cc b/ash/wm/workspace/workspace_event_handler_unittest.cc

index 0046f72f8f1609ac8b79b70ec8f9a28771c9603c..47619d864e306b19b4bfea7115ad15f1b92f0e4c 100644

--- a/ash/wm/workspace/workspace_event_handler_unittest.cc

+++ b/ash/wm/workspace/workspace_event_handler_unittest.cc

@@ -31,7 +31,7 @@ class WorkspaceEventHandlerTest : public test::AshTestBase {

aura::Window* window = new aura::Window(delegate);

window->SetType(aura::client::WINDOW_TYPE_NORMAL);

window->Init(ui::LAYER_TEXTURED);

- window->SetParent(NULL);

+ AddToRootWindow(window);

window->SetBounds(bounds);

window->Show();

return window;