ash/wm/visibility_controller_unittest.cc - Issue 11421006: Desktop aura: Break aura::Window::SetParent in two.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/visibility_controller_unittest.cc

Issue 11421006: Desktop aura: Break aura::Window::SetParent in two. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-add parent finding thing to web_contents_view_aura.cc. I guess it was necessary after all? Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/visibility_controller_unittest.cc

diff --git a/ash/wm/visibility_controller_unittest.cc b/ash/wm/visibility_controller_unittest.cc

index 8a2f0281f2f2644dc0ef851a93b544792d3e6f72..a385edcd24790e8ae065de62fe2b430e58ad0f07 100644

--- a/ash/wm/visibility_controller_unittest.cc

+++ b/ash/wm/visibility_controller_unittest.cc

@@ -22,8 +22,7 @@ TEST_F(VisibilityControllerTest, AnimateHideDoesntHideWindowLayer) {

// We cannot disable animations for this test.

ui::LayerAnimator::set_disable_animations_for_test(false);

- scoped_ptr<aura::Window> container(

- aura::test::CreateTestWindowWithId(-1, NULL));

+ scoped_ptr<aura::Window> container(CreateTestWindowInShellWithId(-1));

SetChildWindowVisibilityChangesAnimated(container.get());

aura::test::TestWindowDelegate d;