ash/wm/toplevel_window_event_handler_unittest.cc - Issue 11421006: Desktop aura: Break aura::Window::SetParent in two.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/toplevel_window_event_handler_unittest.cc

Issue 11421006: Desktop aura: Break aura::Window::SetParent in two. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-add parent finding thing to web_contents_view_aura.cc. I guess it was necessary after all? Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/toplevel_window_event_handler_unittest.cc

diff --git a/ash/wm/toplevel_window_event_handler_unittest.cc b/ash/wm/toplevel_window_event_handler_unittest.cc

index e29df877e980a975fc313f6b9ed1a17a239909f2..b1f4d1aeffa076e0c53c8827aa66d2781855e306 100644

--- a/ash/wm/toplevel_window_event_handler_unittest.cc

+++ b/ash/wm/toplevel_window_event_handler_unittest.cc

@@ -93,7 +93,7 @@ class ToplevelWindowEventHandlerTest : public AshTestBase {

aura::Window* w1 = new aura::Window(d1);

w1->set_id(1);

w1->Init(ui::LAYER_TEXTURED);

- w1->SetParent(parent_);

+ w1->SetParentTo(parent_);

w1->SetBounds(gfx::Rect(0, 0, 100, 100));

w1->Show();

return w1;