ash/root_window_controller_unittest.cc - Issue 11421006: Desktop aura: Break aura::Window::SetParent in two.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/root_window_controller_unittest.cc

Issue 11421006: Desktop aura: Break aura::Window::SetParent in two. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-add parent finding thing to web_contents_view_aura.cc. I guess it was necessary after all? Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/root_window_controller_unittest.cc

diff --git a/ash/root_window_controller_unittest.cc b/ash/root_window_controller_unittest.cc

index c58638a9ff43fdecec52e902052d88e1ddaf6ca2..64531f92aca7336ce28a9604132375a57ab781ca 100644

--- a/ash/root_window_controller_unittest.cc

+++ b/ash/root_window_controller_unittest.cc

@@ -147,8 +147,8 @@ TEST_F(RootWindowControllerTest, MoveWindows_Basic) {

// will not crash.

aura::WindowTracker tracker;

DeleteOnBlurDelegate delete_on_blur_delegate;

- aura::Window* d2 = aura::test::CreateTestWindowWithDelegate(

- &delete_on_blur_delegate, 0, gfx::Rect(50, 50, 100, 100), NULL);

+ aura::Window* d2 = CreateTestWindowInShellWithDelegate(

+ &delete_on_blur_delegate, 0, gfx::Rect(50, 50, 100, 100));

delete_on_blur_delegate.set_window(d2);

root_windows[0]->GetFocusManager()->SetFocusedWindow(

d2, NULL);