ash/display/screen_position_controller_unittest.cc - Issue 11421006: Desktop aura: Break aura::Window::SetParent in two.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/display/screen_position_controller_unittest.cc

Issue 11421006: Desktop aura: Break aura::Window::SetParent in two. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-add parent finding thing to web_contents_view_aura.cc. I guess it was necessary after all? Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/display/screen_position_controller_unittest.cc

diff --git a/ash/display/screen_position_controller_unittest.cc b/ash/display/screen_position_controller_unittest.cc

index 440ae632b566e138e15f218ae46a1cd092194ef3..aa68a30801e2cff6e1401b86d8336a9e73df1bff 100644

--- a/ash/display/screen_position_controller_unittest.cc

+++ b/ash/display/screen_position_controller_unittest.cc

@@ -50,7 +50,7 @@ class ScreenPositionControllerTest : public test::AshTestBase {

window_.reset(new aura::Window(&window_delegate_));

window_->SetType(aura::client::WINDOW_TYPE_NORMAL);

window_->Init(ui::LAYER_NOT_DRAWN);

- window_->SetParent(NULL);

+ AddToRootWindow(window_.get());

window_->set_id(1);

}