Desktop aura: Break aura::Window::SetParent in two.

ash/tooltips/tooltip_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/display/display_controller.h"
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/tooltips/tooltip_controller.h"
 #include "ash/wm/cursor_manager.h"
 #include "base/utf_string_conversions.h"
@@ skipping 26 matching lines @@
     *tooltip = tooltip_text_;
     return true;
   }
 
  private:
   string16 tooltip_text_;
 
   DISALLOW_COPY_AND_ASSIGN(TooltipTestView);
 };
 
-views::Widget* CreateNewWidgetWithBounds(const gfx::Rect& bounds) {
+views::Widget* CreateNewWidgetWithBoundsOn(int display,
+                                           const gfx::Rect& bounds) {
   views::Widget* widget = new views::Widget;
   views::Widget::InitParams params;
   params.type = views::Widget::InitParams::TYPE_WINDOW_FRAMELESS;
   params.accept_events = true;
   params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+  params.context = Shell::GetAllRootWindows().at(display);
   params.parent_widget = NULL;
   params.child = true;
   params.bounds = bounds;
   widget->Init(params);
   widget->Show();
   return widget;
 }
 
-views::Widget* CreateNewWidget() {
-  return CreateNewWidgetWithBounds(gfx::Rect());
+views::Widget* CreateNewWidgetOn(int display) {
+  return CreateNewWidgetWithBoundsOn(display, gfx::Rect());
 }
 
 void AddViewToWidgetAndResize(views::Widget* widget, views::View* view) {
   if (!widget->GetContentsView()) {
     views::View* contents_view = new views::View;
     widget->SetContentsView(contents_view);
   }
 
   views::View* contents_view = widget->GetContentsView();
   contents_view->AddChildView(view);
@@ skipping 66 matching lines @@
 
 TEST_F(TooltipControllerTest, NonNullTooltipClient) {
   EXPECT_TRUE(aura::client::GetTooltipClient(Shell::GetPrimaryRootWindow())
               != NULL);
   EXPECT_EQ(string16(), GetTooltipText());
   EXPECT_EQ(NULL, GetTooltipWindow());
   EXPECT_FALSE(IsTooltipVisible());
 }
 
 TEST_F(TooltipControllerTest, ViewTooltip) {
-  scoped_ptr<views::Widget> widget(CreateNewWidget());
+  scoped_ptr<views::Widget> widget(CreateNewWidgetOn(0));
   TooltipTestView* view = new TooltipTestView;
   AddViewToWidgetAndResize(widget.get(), view);
   view->set_tooltip_text(ASCIIToUTF16("Tooltip Text"));
   EXPECT_EQ(string16(), GetTooltipText());
   EXPECT_EQ(NULL, GetTooltipWindow());
   aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
   generator.MoveMouseToCenterOf(widget->GetNativeView());
 
   aura::Window* window = widget->GetNativeView();
   EXPECT_EQ(window, Shell::GetPrimaryRootWindow()->GetEventHandlerForPoint(
       generator.current_location()));
   string16 expected_tooltip = ASCIIToUTF16("Tooltip Text");
   EXPECT_EQ(expected_tooltip, aura::client::GetTooltipText(window));
   EXPECT_EQ(string16(), GetTooltipText());
   EXPECT_EQ(window, GetTooltipWindow());
 
   // Fire tooltip timer so tooltip becomes visible.
   FireTooltipTimer();
 
   EXPECT_TRUE(IsTooltipVisible());
   generator.MoveMouseBy(1, 0);
 
   EXPECT_TRUE(IsTooltipVisible());
   EXPECT_EQ(expected_tooltip, aura::client::GetTooltipText(window));
   EXPECT_EQ(expected_tooltip, GetTooltipText());
   EXPECT_EQ(window, GetTooltipWindow());
 }
 
 TEST_F(TooltipControllerTest, TooltipsInMultipleViews) {
-  scoped_ptr<views::Widget> widget(CreateNewWidget());
+  scoped_ptr<views::Widget> widget(CreateNewWidgetOn(0));
   TooltipTestView* view1 = new TooltipTestView;
   AddViewToWidgetAndResize(widget.get(), view1);
   view1->set_tooltip_text(ASCIIToUTF16("Tooltip Text"));
   EXPECT_EQ(string16(), GetTooltipText());
   EXPECT_EQ(NULL, GetTooltipWindow());
 
   TooltipTestView* view2 = new TooltipTestView;
   AddViewToWidgetAndResize(widget.get(), view2);
 
   aura::Window* window = widget->GetNativeView();
@@ skipping 22 matching lines @@
         Shell::GetPrimaryRootWindow()->GetEventHandlerForPoint(
             generator.current_location()));
     string16 expected_tooltip;  // = ""
     EXPECT_EQ(expected_tooltip, aura::client::GetTooltipText(window));
     EXPECT_EQ(expected_tooltip, GetTooltipText());
     EXPECT_EQ(window, GetTooltipWindow());
   }
 }
 
 TEST_F(TooltipControllerTest, EnableOrDisableTooltips) {
-  scoped_ptr<views::Widget> widget(CreateNewWidget());
+  scoped_ptr<views::Widget> widget(CreateNewWidgetOn(0));
   TooltipTestView* view = new TooltipTestView;
   AddViewToWidgetAndResize(widget.get(), view);
   view->set_tooltip_text(ASCIIToUTF16("Tooltip Text"));
   EXPECT_EQ(string16(), GetTooltipText());
   EXPECT_EQ(NULL, GetTooltipWindow());
 
   aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
   generator.MoveMouseRelativeTo(widget->GetNativeView(),
                                 view->bounds().CenterPoint());
   string16 expected_tooltip = ASCIIToUTF16("Tooltip Text");
 
   // Fire tooltip timer so tooltip becomes visible.
   FireTooltipTimer();
   EXPECT_TRUE(IsTooltipVisible());
 
   // Diable tooltips and check again.
   GetController()->SetTooltipsEnabled(false);
   EXPECT_FALSE(IsTooltipVisible());
   FireTooltipTimer();
   EXPECT_FALSE(IsTooltipVisible());
 
   // Enable tooltips back and check again.
   GetController()->SetTooltipsEnabled(true);
   EXPECT_FALSE(IsTooltipVisible());
   FireTooltipTimer();
   EXPECT_TRUE(IsTooltipVisible());
 }
 
 TEST_F(TooltipControllerTest, HideTooltipWhenCursorHidden) {
-  scoped_ptr<views::Widget> widget(CreateNewWidget());
+  scoped_ptr<views::Widget> widget(CreateNewWidgetOn(0));
   TooltipTestView* view = new TooltipTestView;
   AddViewToWidgetAndResize(widget.get(), view);
   view->set_tooltip_text(ASCIIToUTF16("Tooltip Text"));
   EXPECT_EQ(string16(), GetTooltipText());
   EXPECT_EQ(NULL, GetTooltipWindow());
 
   aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
   generator.MoveMouseRelativeTo(widget->GetNativeView(),
                                 view->bounds().CenterPoint());
   string16 expected_tooltip = ASCIIToUTF16("Tooltip Text");
@@ skipping 99 matching lines @@
   tooltip.clear();
   max_width = line_count = -1;
   tooltip = ASCIIToUTF16("Small  Tool  t\tip");
   TrimTooltipToFit(&tooltip, &max_width, &line_count, 0, 0);
   EXPECT_EQ(font.GetStringWidth(ASCIIToUTF16("Small  Tool  t\tip")), max_width);
   EXPECT_EQ(1, line_count);
   EXPECT_EQ(ASCIIToUTF16("Small  Tool  t\tip"), tooltip);
 }
 
 TEST_F(TooltipControllerTest, TooltipHidesOnKeyPressAndStaysHiddenUntilChange) {
-  scoped_ptr<views::Widget> widget(CreateNewWidget());
+  scoped_ptr<views::Widget> widget(CreateNewWidgetOn(0));
   TooltipTestView* view1 = new TooltipTestView;
   AddViewToWidgetAndResize(widget.get(), view1);
   view1->set_tooltip_text(ASCIIToUTF16("Tooltip Text for view 1"));
   EXPECT_EQ(string16(), GetTooltipText());
   EXPECT_EQ(NULL, GetTooltipWindow());
 
   TooltipTestView* view2 = new TooltipTestView;
   AddViewToWidgetAndResize(widget.get(), view2);
   view2->set_tooltip_text(ASCIIToUTF16("Tooltip Text for view 2"));
 
@@ skipping 34 matching lines @@
   FireTooltipTimer();
   EXPECT_TRUE(IsTooltipVisible());
   EXPECT_TRUE(IsTooltipShownTimerRunning());
   string16 expected_tooltip = ASCIIToUTF16("Tooltip Text for view 2");
   EXPECT_EQ(expected_tooltip, aura::client::GetTooltipText(window));
   EXPECT_EQ(expected_tooltip, GetTooltipText());
   EXPECT_EQ(window, GetTooltipWindow());
 }
 
 TEST_F(TooltipControllerTest, TooltipHidesOnTimeoutAndStaysHiddenUntilChange) {
-  scoped_ptr<views::Widget> widget(CreateNewWidget());
+  scoped_ptr<views::Widget> widget(CreateNewWidgetOn(0));
   TooltipTestView* view1 = new TooltipTestView;
   AddViewToWidgetAndResize(widget.get(), view1);
   view1->set_tooltip_text(ASCIIToUTF16("Tooltip Text for view 1"));
   EXPECT_EQ(string16(), GetTooltipText());
   EXPECT_EQ(NULL, GetTooltipWindow());
 
   TooltipTestView* view2 = new TooltipTestView;
   AddViewToWidgetAndResize(widget.get(), view2);
   view2->set_tooltip_text(ASCIIToUTF16("Tooltip Text for view 2"));
 
@@ skipping 36 matching lines @@
   EXPECT_TRUE(IsTooltipShownTimerRunning());
   string16 expected_tooltip = ASCIIToUTF16("Tooltip Text for view 2");
   EXPECT_EQ(expected_tooltip, aura::client::GetTooltipText(window));
   EXPECT_EQ(expected_tooltip, GetTooltipText());
   EXPECT_EQ(window, GetTooltipWindow());
 }
 
 TEST_F(TooltipControllerTest, TooltipsOnMultiDisplayShouldNotCrash) {
   UpdateDisplay("1000x600,600x400");
   Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
-  scoped_ptr<views::Widget> widget1(CreateNewWidgetWithBounds(
-      gfx::Rect(10, 10, 100, 100)));
+  scoped_ptr<views::Widget> widget1(CreateNewWidgetWithBoundsOn(
+      0, gfx::Rect(10, 10, 100, 100)));
   TooltipTestView* view1 = new TooltipTestView;
   AddViewToWidgetAndResize(widget1.get(), view1);
   view1->set_tooltip_text(ASCIIToUTF16("Tooltip Text for view 1"));
   EXPECT_EQ(widget1->GetNativeView()->GetRootWindow(), root_windows[0]);
 
-  scoped_ptr<views::Widget> widget2(CreateNewWidgetWithBounds(
-      gfx::Rect(1200, 10, 100, 100)));
+  scoped_ptr<views::Widget> widget2(CreateNewWidgetWithBoundsOn(
+      1, gfx::Rect(1200, 10, 100, 100)));
   TooltipTestView* view2 = new TooltipTestView;
   AddViewToWidgetAndResize(widget2.get(), view2);
   view2->set_tooltip_text(ASCIIToUTF16("Tooltip Text for view 2"));
   EXPECT_EQ(widget2->GetNativeView()->GetRootWindow(), root_windows[1]);
 
   // Show tooltip on second display.
   aura::test::EventGenerator generator(root_windows[1]);
   generator.MoveMouseRelativeTo(widget2->GetNativeView(),
                                 view2->bounds().CenterPoint());
   FireTooltipTimer();
@@ skipping 14 matching lines @@
   // be able to show tooltips on the primary display.
   aura::test::EventGenerator generator1(root_windows[0]);
   generator1.MoveMouseRelativeTo(widget1->GetNativeView(),
                                  view1->bounds().CenterPoint());
   FireTooltipTimer();
   EXPECT_TRUE(IsTooltipVisible());
 }
 
 }  // namespace test
 }  // namespace ash