Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1142083002: Terminate the ViewManagerInit app when its binding has a connection error. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Terminate the ViewManagerInit app when its binding has a connection error. This is split off https://codereview.chromium.org/1139673003 BUG=484234 Committed: https://crrev.com/5a47aeab37fa502678af63974f1477c17565b200 Cr-Commit-Position: refs/heads/master@{#330382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M components/view_manager/public/cpp/lib/view_manager_init.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M components/view_manager/public/cpp/view_manager_init.h View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 7 months ago (2015-05-18 16:20:20 UTC) #2
sky
LGTM
5 years, 7 months ago (2015-05-18 16:53:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142083002/1
5 years, 7 months ago (2015-05-18 17:01:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 20:01:35 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:40:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a47aeab37fa502678af63974f1477c17565b200
Cr-Commit-Position: refs/heads/master@{#330382}

Powered by Google App Engine
This is Rietveld 408576698