Chromium Code Reviews| Index: components/tracing/child_trace_message_filter.h |
| diff --git a/components/tracing/child_trace_message_filter.h b/components/tracing/child_trace_message_filter.h |
| index a6453a3e640acb79704c64c89b449147614b8af8..d380b4afefc315ffff4aab496689e295bbaafda0 100644 |
| --- a/components/tracing/child_trace_message_filter.h |
| +++ b/components/tracing/child_trace_message_filter.h |
| @@ -11,7 +11,7 @@ |
| #include "ipc/message_filter.h" |
| namespace base { |
| -class MessageLoopProxy; |
| +class SingleThreadTaskRunner; |
| } |
| namespace tracing { |
| @@ -19,7 +19,8 @@ namespace tracing { |
| // This class sends and receives trace messages on child processes. |
| class ChildTraceMessageFilter : public IPC::MessageFilter { |
| public: |
| - explicit ChildTraceMessageFilter(base::MessageLoopProxy* ipc_message_loop); |
| + explicit ChildTraceMessageFilter( |
| + base::SingleThreadTaskRunner* ipc_task_runner); |
| // IPC::MessageFilter implementation. |
| void OnFilterAdded(IPC::Sender* sender) override; |
| @@ -30,7 +31,9 @@ class ChildTraceMessageFilter : public IPC::MessageFilter { |
| const base::trace_event::MemoryDumpRequestArgs& args, |
| const base::trace_event::MemoryDumpCallback& callback); |
| - base::MessageLoopProxy* ipc_message_loop() const { return ipc_message_loop_; } |
| + base::SingleThreadTaskRunner* ipc_task_runner() const { |
| + return ipc_task_runner_; |
| + } |
| protected: |
| ~ChildTraceMessageFilter() override; |
| @@ -67,7 +70,7 @@ class ChildTraceMessageFilter : public IPC::MessageFilter { |
| void OnProcessMemoryDumpDone(uint64 dump_guid, bool success); |
| IPC::Sender* sender_; |
| - base::MessageLoopProxy* ipc_message_loop_; |
|
no sievers
2015/05/20 23:02:38
weird that this doesn't hold a ref
Sami
2015/05/21 11:39:48
Yeah, that seems a little dodgy. I'll fix that sep
|
| + base::SingleThreadTaskRunner* ipc_task_runner_; |
| // guid of the outstanding request (to the Browser's MemoryDumpManager), if |
| // any. 0 if there is no request pending. |