content/child: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

content/child: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

This patch was mostly autogenerated with
https://codereview.chromium.org/1010073002/.

BUG=465354
TBR=jochen@chromium.org,raymes@chromium.org

Committed: https://crrev.com/12262cfcdbfd13d853dc358ca600bfc499e31ad5
Cr-Commit-Position: refs/heads/master@{#330939}

[Sami, 2015-05-20 14:03:06]

skyostil@chromium.org changed reviewers:
+ sievers@chromium.org

[Sami, 2015-05-20 14:04:14]

PTAL. Sorry this one is a bit sprawling because the content/child interfaces are
used in a bunch of places. To limit the scope I've purposefully left some
interfaces outside content/child as they are -- I'll deal with those in later
patches.

[no sievers, 2015-05-20 23:02:39]

lgtm

https://codereview.chromium.org/1142063003/diff/40001/components/nacl/rendere...
File components/nacl/renderer/pnacl_translation_resource_host.cc (right):

https://codereview.chromium.org/1142063003/diff/40001/components/nacl/rendere...
components/nacl/renderer/pnacl_translation_resource_host.cc:14:
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner)
nit: const ref as before

https://codereview.chromium.org/1142063003/diff/40001/components/tracing/chil...
File components/tracing/child_trace_message_filter.h (left):

https://codereview.chromium.org/1142063003/diff/40001/components/tracing/chil...
components/tracing/child_trace_message_filter.h:70: base::MessageLoopProxy*
ipc_message_loop_;
weird that this doesn't hold a ref

https://codereview.chromium.org/1142063003/diff/40001/content/child/child_thr...
File content/child/child_thread_impl.cc (right):

https://codereview.chromium.org/1142063003/diff/40001/content/child/child_thr...
content/child/child_thread_impl.cc:320:
base::ThreadTaskRunnerHandle::Get().get(), sync_message_filter_.get());
You can actually use message_loop_.task_runner() which was assigned above.

https://codereview.chromium.org/1142063003/diff/40001/content/child/child_thr...
content/child/child_thread_impl.cc:400:
base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
nit: Maybe just do message_loop_->task_runner() here also like below?

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
File content/renderer/media/audio_input_message_filter.cc (right):

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
content/renderer/media/audio_input_message_filter.cc:56:
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner)
nit: const ref as before?

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
File content/renderer/media/audio_input_message_filter.h (right):

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
content/renderer/media/audio_input_message_filter.h:29:
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner);
nit: const ref as before?

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
File content/renderer/media/audio_message_filter.h (right):

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
content/renderer/media/audio_message_filter.h:32:
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner);
..

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
File content/renderer/media/media_stream_video_track.cc (right):

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_track.cc:37:
FrameDeliverer(scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
..

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/pepper...
File content/renderer/pepper/pepper_media_stream_video_track_host.cc (right):

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/pepper...
content/renderer/pepper/pepper_media_stream_video_track_host.cc:436:
frame_deliverer_ = new FrameDeliverer(io_task_runner(), frame_callback);
Ah I see now why you changed some of these from const-ref to stack-instance.
Because you changed the getter(s) the opposite way :) Fair enough...

[Sami, 2015-05-21 11:39:49]

https://codereview.chromium.org/1142063003/diff/40001/components/nacl/rendere...
File components/nacl/renderer/pnacl_translation_resource_host.cc (right):

https://codereview.chromium.org/1142063003/diff/40001/components/nacl/rendere...
components/nacl/renderer/pnacl_translation_resource_host.cc:14:
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner)
On 2015/05/20 23:02:38, sievers wrote:
> nit: const ref as before

I changed these to pass-by-value since Dana asked for that in
https://codereview.chromium.org/1100773004. Looks like scoped_refptr supports
move semantics so this should be as efficient as before.

https://codereview.chromium.org/1142063003/diff/40001/components/tracing/chil...
File components/tracing/child_trace_message_filter.h (left):

https://codereview.chromium.org/1142063003/diff/40001/components/tracing/chil...
components/tracing/child_trace_message_filter.h:70: base::MessageLoopProxy*
ipc_message_loop_;
On 2015/05/20 23:02:38, sievers wrote:
> weird that this doesn't hold a ref

Yeah, that seems a little dodgy. I'll fix that separately.

https://codereview.chromium.org/1142063003/diff/40001/content/child/child_thr...
File content/child/child_thread_impl.cc (right):

https://codereview.chromium.org/1142063003/diff/40001/content/child/child_thr...
content/child/child_thread_impl.cc:320:
base::ThreadTaskRunnerHandle::Get().get(), sync_message_filter_.get());
On 2015/05/20 23:02:38, sievers wrote:
> You can actually use message_loop_.task_runner() which was assigned above.

Thanks for the tip, done.

https://codereview.chromium.org/1142063003/diff/40001/content/child/child_thr...
content/child/child_thread_impl.cc:400:
base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
On 2015/05/20 23:02:38, sievers wrote:
> nit: Maybe just do message_loop_->task_runner() here also like below?

Done.

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
File content/renderer/media/audio_input_message_filter.cc (right):

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
content/renderer/media/audio_input_message_filter.cc:56:
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner)
On 2015/05/20 23:02:38, sievers wrote:
> nit: const ref as before?

Ditto.

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
File content/renderer/media/audio_input_message_filter.h (right):

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
content/renderer/media/audio_input_message_filter.h:29:
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner);
On 2015/05/20 23:02:38, sievers wrote:
> nit: const ref as before?

Ditto.

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
File content/renderer/media/audio_message_filter.h (right):

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
content/renderer/media/audio_message_filter.h:32:
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner);
On 2015/05/20 23:02:38, sievers wrote:
> ..

Ditto :)

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
File content/renderer/media/media_stream_video_track.cc (right):

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/media/...
content/renderer/media/media_stream_video_track.cc:37:
FrameDeliverer(scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
On 2015/05/20 23:02:38, sievers wrote:
> ..

Ditto.

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/pepper...
File content/renderer/pepper/pepper_media_stream_video_track_host.cc (right):

https://codereview.chromium.org/1142063003/diff/40001/content/renderer/pepper...
content/renderer/pepper/pepper_media_stream_video_track_host.cc:436:
frame_deliverer_ = new FrameDeliverer(io_task_runner(), frame_callback);
On 2015/05/20 23:02:39, sievers wrote:
> Ah I see now why you changed some of these from const-ref to stack-instance.
> Because you changed the getter(s) the opposite way :) Fair enough...

Yeah, this also fits better but the main motivation was to take advantage of
move semantics.

[Sami, 2015-05-21 13:20:39]

skyostil@chromium.org changed reviewers:
+ jochen@chromium.org, raymes@chromium.org

[Sami, 2015-05-21 13:21:26]

Thanks again Daniel. TBR'ing chrome/ and components/ for jochen@ and ppapi/ to
raymes@ since those parts are just cosmetic changes to match the new interfaces.

[Sami, 2015-05-21 13:21:36]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2015-05-21 13:21:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1142063003/#ps80001
(title: "Build fix.")

[commit-bot: I haz the power, 2015-05-21 13:21:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1142063003/80001

[commit-bot: I haz the power, 2015-05-21 14:49:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-21 14:50:38]

Patchset 5 (id:??) landed as
https://crrev.com/12262cfcdbfd13d853dc358ca600bfc499e31ad5
Cr-Commit-Position: refs/heads/master@{#330939}