Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1142053004: Empty picture shaders should draw nothing. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
f(malita), mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Empty picture shaders should draw nothing. BUG=skia: Committed: https://skia.googlesource.com/skia/+/cfa90a1aaff2ffbb71a8597905607287856601e5

Patch Set 1 #

Patch Set 2 : EmptyShader #

Patch Set 3 : ref counting #

Patch Set 4 : sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M src/core/SkPictureShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureShader.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M tests/PictureShaderTest.cpp View 1 2 3 1 chunk +23 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mtklein_C
5 years, 7 months ago (2015-05-18 20:26:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142053004/40001
5 years, 7 months ago (2015-05-18 20:26:50 UTC) #4
f(malita)
LGTM, thanks!
5 years, 7 months ago (2015-05-18 20:29:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142053004/60001
5 years, 7 months ago (2015-05-18 20:31:24 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 20:44:43 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/cfa90a1aaff2ffbb71a8597905607287856601e5

Powered by Google App Engine
This is Rietveld 408576698