Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: third_party/mojo/src/mojo/public/tools/git/dart_pub_get.py

Issue 1142043005: Update mojo sdk to rev 1dc8a9a5db73d3718d99917fadf31f5fb2ebad4f (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix type conversion errors on win64 for some msvs Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/mojo/src/mojo/public/tools/download_network_service.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/mojo/src/mojo/public/tools/git/dart_pub_get.py
diff --git a/third_party/mojo/src/mojo/public/tools/git/dart_pub_get.py b/third_party/mojo/src/mojo/public/tools/git/dart_pub_get.py
index a984de98d2e838c077e23bd9a2a56a3895aaeea3..f2b0ddc3b17896095ed2a2adf208847cf0d36eb9 100755
--- a/third_party/mojo/src/mojo/public/tools/git/dart_pub_get.py
+++ b/third_party/mojo/src/mojo/public/tools/git/dart_pub_get.py
@@ -24,10 +24,16 @@ def pub_get(dart_sdk_path, target_directory):
# simultaneous builds in different repos stomping on each other.
env = os.environ.copy()
env["PUB_CACHE"] = os.path.join(os.getcwd(), "dart-pub-cache")
- subprocess.check_output(cmd, shell=False,
- stderr=subprocess.STDOUT,
- cwd=target_directory,
- env=env)
+ try:
+ subprocess.check_output(cmd, shell=False,
+ stderr=subprocess.STDOUT,
+ cwd=target_directory,
+ env=env)
+ except subprocess.CalledProcessError as e:
+ print('Error running pub get in %s' % target_directory)
+ print(e.output)
+ raise e
+
def main(repository_root, dart_sdk_path, dirs_to_ignore):
« no previous file with comments | « third_party/mojo/src/mojo/public/tools/download_network_service.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698