Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: third_party/mojo/src/mojo/public/tools/dart_analyze.py

Issue 1142043005: Update mojo sdk to rev 1dc8a9a5db73d3718d99917fadf31f5fb2ebad4f (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix type conversion errors on win64 for some msvs Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/mojo/src/mojo/public/tools/dart_analyze.py
diff --git a/third_party/mojo/src/mojo/public/tools/dart_analyze.py b/third_party/mojo/src/mojo/public/tools/dart_analyze.py
index b90cbef558dd3652c409b7767ca2fb32598cf85f..6e7dfc428bdabe5565b102e593df0880ed3164a2 100755
--- a/third_party/mojo/src/mojo/public/tools/dart_analyze.py
+++ b/third_party/mojo/src/mojo/public/tools/dart_analyze.py
@@ -31,6 +31,9 @@ _IGNORED_PATTERNS = [
re.compile(r'.*is a part and can not|^Only libraries can be analyzed'),
# TODO: Remove this once dev SDK includes Uri.directory constructor.
re.compile(r'.*The class \'Uri\' does not have a constructor \'directory\''),
+ # TODO: Remove this once Sky no longer generates this warning.
+ # dartbug.com/22836
+ re.compile(r'.*cannot both be unnamed'),
]
def _success(stamp_file):
@@ -66,7 +69,7 @@ def main(args):
cmd.extend(dart_files)
cmd.extend(args)
- cmd.append("--package-root=%s" % temp_dir)
+ cmd.append("--package-root=%s/packages" % temp_dir)
cmd.append("--fatal-warnings")
errors = 0
« no previous file with comments | « third_party/mojo/src/mojo/public/tools/bindings/mojom.gni ('k') | third_party/mojo/src/mojo/public/tools/dart_list_mojoms.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698