third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_python_generator.py - Issue 1142043005: Update mojo sdk to rev 1dc8a9a5db73d3718d99917fadf31f5fb2ebad4f

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_python_generator.py

Issue 1142043005: Update mojo sdk to rev 1dc8a9a5db73d3718d99917fadf31f5fb2ebad4f (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix type conversion errors on win64 for some msvs Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_java_generator.py ('k') | third_party/mojo/src/mojo/public/tools/bindings/mojom.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_python_generator.py

diff --git a/third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_python_generator.py b/third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_python_generator.py

index 6fc5b976a43b304de9bb4495ab08a3b81499fc27..1f726b6699a9bb31ba226dc39885df38006be90b 100644

--- a/third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_python_generator.py

+++ b/third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_python_generator.py

@@ -81,7 +81,8 @@ def FieldStyle(name):

def GetNameForElement(element):

if (mojom.IsEnumKind(element) or mojom.IsInterfaceKind(element) or

- mojom.IsStructKind(element) or isinstance(element, mojom.Method)):

+ mojom.IsStructKind(element) or mojom.IsUnionKind(element) or

+ isinstance(element, mojom.Method)):

return UpperCamelCase(element.name)

if isinstance(element, mojom.EnumValue):

return (GetNameForElement(element.enum) + '.' +

@@ -145,7 +146,7 @@ def GetFieldType(kind, field=None):

arguments.append('nullable=True')

return '_descriptor.MapType(%s)' % ', '.join(arguments)

- if mojom.IsStructKind(kind):

+ if mojom.IsStructKind(kind) or mojom.IsUnionKind(kind):

arguments = [ 'lambda: %s' % GetFullyQualifiedName(kind) ]

if mojom.IsNullableKind(kind):

arguments.append('nullable=True')