Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1142043003: Use USE_SIMULATOR when appropriate. (Closed)

Created:
5 years, 7 months ago by Sven Panne
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use USE_SIMULATOR when appropriate. Committed: https://crrev.com/2470bca2dedfe64f533d3fa33e23b4e9723ce6c1 Cr-Commit-Position: refs/heads/master@{#28462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -27 lines) Patch
M src/isolate.h View 5 chunks +4 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142043003/1
5 years, 7 months ago (2015-05-18 14:24:24 UTC) #2
Sven Panne
5 years, 7 months ago (2015-05-18 14:32:11 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-18 15:01:01 UTC) #6
Hannes Payer (out of office)
lgtm
5 years, 7 months ago (2015-05-19 05:00:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142043003/1
5 years, 7 months ago (2015-05-19 05:54:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 05:56:53 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 05:57:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2470bca2dedfe64f533d3fa33e23b4e9723ce6c1
Cr-Commit-Position: refs/heads/master@{#28462}

Powered by Google App Engine
This is Rietveld 408576698