Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1142043002: Add NULL check of ExecutionContext in ServiceWorkerContainer (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, bashi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add NULL check of ExecutionContext in ServiceWorkerContainter::getRegistration and ServiceWorkerContainter::registerServiceWorker In a worker thread, scriptState->executionContext() can return null when V8::TerminateExecution() signal is sent by main thread. (See crbug.com/413518 for more details). This patch adds a null check to avoid crash. BUG=413518 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195505

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-18 09:40:04 UTC) #2
kinuko
(+ksakamoto, bashi) This lgtm but I'd like to defer this to ksakamoto@ (to see whether ...
5 years, 7 months ago (2015-05-18 09:56:03 UTC) #4
Pranay
Sure. Thanks :)
5 years, 7 months ago (2015-05-18 10:20:01 UTC) #5
Kunihiko Sakamoto
On 2015/05/18 09:56:03, kinuko wrote: > (+ksakamoto, bashi) > > This lgtm but I'd like ...
5 years, 7 months ago (2015-05-18 10:21:41 UTC) #6
Kunihiko Sakamoto
lgtm lgtm Talked with bashi@. We need empty checks everywhere we call V8 API.
5 years, 7 months ago (2015-05-19 01:33:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142043002/20001
5 years, 7 months ago (2015-05-19 01:33:57 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 02:50:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195505

Powered by Google App Engine
This is Rietveld 408576698