Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1142033002: Oilpan: remove incorrect LayoutPart transition type usage. (Closed)

Created:
5 years, 7 months ago by huayong.xu
Modified:
5 years, 7 months ago
Reviewers:
haraken, sof
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: remove incorrect LayoutPart transition type usage. This is cleanup of https://codereview.chromium.org/869323003. BUG=398342 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/layout/LayoutPart.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
huayong.xu
LayoutPart is also a LayoutObject. It should also be moved off heap, is it right? ...
5 years, 7 months ago (2015-05-18 08:11:54 UTC) #2
haraken
LGTM How did you notice this? We need to fix all of these errors...
5 years, 7 months ago (2015-05-18 08:13:39 UTC) #3
sof
On 2015/05/18 08:13:39, haraken wrote: > LGTM > > How did you notice this? We ...
5 years, 7 months ago (2015-05-18 08:19:32 UTC) #4
sof
lgtm, could you update the description to something like Oilpan: remove incorrect LayoutPart transition type ...
5 years, 7 months ago (2015-05-18 08:20:35 UTC) #5
huayong.xu
On 2015/05/18 08:13:39, haraken wrote: > LGTM > > How did you notice this? We ...
5 years, 7 months ago (2015-05-18 08:30:33 UTC) #6
huayong.xu
On 2015/05/18 08:20:35, sof wrote: > lgtm, could you update the description to something like ...
5 years, 7 months ago (2015-05-18 08:31:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142033002/1
5 years, 7 months ago (2015-05-18 08:32:33 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 09:52:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195459

Powered by Google App Engine
This is Rietveld 408576698