Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 114203002: Add named options to push-to-trunk script. (Closed)

Created:
7 years ago by Michael Achenbach
Modified:
7 years ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Add named options to push-to-trunk script. Also make sure that on exceptions from the test infrastructure there is no retry. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -28 lines) Patch
M tools/push-to-trunk/auto_roll.py View 2 chunks +7 lines, -1 line 0 comments Download
M tools/push-to-trunk/common_includes.py View 9 chunks +22 lines, -12 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 5 chunks +14 lines, -4 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 7 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years ago (2013-12-12 16:52:21 UTC) #1
ulan
lgtm
7 years ago (2013-12-16 10:03:02 UTC) #2
Michael Achenbach
7 years ago (2013-12-16 10:56:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18313.

Powered by Google App Engine
This is Rietveld 408576698