Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Unified Diff: media/filters/ffmpeg_audio_decoder.cc

Issue 11420070: Remove locking from FFmpegDemuxerStream and associated TODOs from media code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/ffmpeg_audio_decoder.h ('k') | media/filters/ffmpeg_demuxer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_audio_decoder.cc
diff --git a/media/filters/ffmpeg_audio_decoder.cc b/media/filters/ffmpeg_audio_decoder.cc
index a74d7dd2cbb3a053304bf11ba33de7c45ec92779..c0251ffeacc1f4e6f477b7e5020f4cfcaec484d5 100644
--- a/media/filters/ffmpeg_audio_decoder.cc
+++ b/media/filters/ffmpeg_audio_decoder.cc
@@ -189,12 +189,17 @@ void FFmpegAudioDecoder::DoRead(const ReadCB& read_cb) {
void FFmpegAudioDecoder::DoDecodeBuffer(
DemuxerStream::Status status,
const scoped_refptr<DecoderBuffer>& input) {
- DCHECK(message_loop_->BelongsToCurrentThread());
+ if (!message_loop_->BelongsToCurrentThread()) {
+ message_loop_->PostTask(FROM_HERE, base::Bind(
+ &FFmpegAudioDecoder::DoDecodeBuffer, this, status, input));
+ return;
+ }
+
DCHECK(!read_cb_.is_null());
DCHECK(queued_audio_.empty());
+ DCHECK_EQ(status != DemuxerStream::kOk, !input) << status;
if (status != DemuxerStream::kOk) {
- DCHECK(!input);
// TODO(acolwell): Add support for reinitializing the decoder when
// |status| == kConfigChanged. For now we just trigger a decode error.
AudioDecoder::Status decoder_status =
@@ -365,18 +370,7 @@ void FFmpegAudioDecoder::DoDecodeBuffer(
void FFmpegAudioDecoder::ReadFromDemuxerStream() {
DCHECK(!read_cb_.is_null());
- demuxer_stream_->Read(base::Bind(&FFmpegAudioDecoder::DecodeBuffer, this));
-}
-
-void FFmpegAudioDecoder::DecodeBuffer(
- DemuxerStream::Status status,
- const scoped_refptr<DecoderBuffer>& buffer) {
- DCHECK_EQ(status != DemuxerStream::kOk, !buffer) << status;
-
- // TODO(scherkus): fix FFmpegDemuxerStream::Read() to not execute our read
- // callback on the same execution stack so we can get rid of forced task post.
- message_loop_->PostTask(FROM_HERE, base::Bind(
- &FFmpegAudioDecoder::DoDecodeBuffer, this, status, buffer));
+ demuxer_stream_->Read(base::Bind(&FFmpegAudioDecoder::DoDecodeBuffer, this));
}
base::TimeDelta FFmpegAudioDecoder::GetNextOutputTimestamp() const {
@@ -385,4 +379,5 @@ base::TimeDelta FFmpegAudioDecoder::GetNextOutputTimestamp() const {
base::Time::kMicrosecondsPerSecond;
return output_timestamp_base_ + base::TimeDelta::FromMicroseconds(decoded_us);
}
+
} // namespace media
« no previous file with comments | « media/filters/ffmpeg_audio_decoder.h ('k') | media/filters/ffmpeg_demuxer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698