Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: media/filters/ffmpeg_audio_decoder.h

Issue 11420070: Remove locking from FFmpegDemuxerStream and associated TODOs from media code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « media/filters/decrypting_video_decoder.cc ('k') | media/filters/ffmpeg_audio_decoder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_FILTERS_FFMPEG_AUDIO_DECODER_H_ 5 #ifndef MEDIA_FILTERS_FFMPEG_AUDIO_DECODER_H_
6 #define MEDIA_FILTERS_FFMPEG_AUDIO_DECODER_H_ 6 #define MEDIA_FILTERS_FFMPEG_AUDIO_DECODER_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 void DoInitialize(const scoped_refptr<DemuxerStream>& stream, 49 void DoInitialize(const scoped_refptr<DemuxerStream>& stream,
50 const PipelineStatusCB& status_cb, 50 const PipelineStatusCB& status_cb,
51 const StatisticsCB& statistics_cb); 51 const StatisticsCB& statistics_cb);
52 void DoReset(const base::Closure& closure); 52 void DoReset(const base::Closure& closure);
53 void DoRead(const ReadCB& read_cb); 53 void DoRead(const ReadCB& read_cb);
54 void DoDecodeBuffer(DemuxerStream::Status status, 54 void DoDecodeBuffer(DemuxerStream::Status status,
55 const scoped_refptr<DecoderBuffer>& input); 55 const scoped_refptr<DecoderBuffer>& input);
56 56
57 // Reads from the demuxer stream with corresponding callback method. 57 // Reads from the demuxer stream with corresponding callback method.
58 void ReadFromDemuxerStream(); 58 void ReadFromDemuxerStream();
59 void DecodeBuffer(DemuxerStream::Status status,
60 const scoped_refptr<DecoderBuffer>& buffer);
61 59
62 // Returns the timestamp that should be used for the next buffer returned 60 // Returns the timestamp that should be used for the next buffer returned
63 // via |read_cb_|. It is calculated from |output_timestamp_base_| and 61 // via |read_cb_|. It is calculated from |output_timestamp_base_| and
64 // |total_frames_decoded_|. 62 // |total_frames_decoded_|.
65 base::TimeDelta GetNextOutputTimestamp() const; 63 base::TimeDelta GetNextOutputTimestamp() const;
66 64
67 // This is !is_null() iff Initialize() hasn't been called. 65 // This is !is_null() iff Initialize() hasn't been called.
68 MessageLoopFactoryCB message_loop_factory_cb_; 66 MessageLoopFactoryCB message_loop_factory_cb_;
69 67
70 scoped_refptr<base::MessageLoopProxy> message_loop_; 68 scoped_refptr<base::MessageLoopProxy> message_loop_;
(...skipping 25 matching lines...) Expand all
96 // Since multiple frames may be decoded from the same packet we need to queue 94 // Since multiple frames may be decoded from the same packet we need to queue
97 // them up and hand them out as we receive Read() calls. 95 // them up and hand them out as we receive Read() calls.
98 std::list<QueuedAudioBuffer> queued_audio_; 96 std::list<QueuedAudioBuffer> queued_audio_;
99 97
100 DISALLOW_IMPLICIT_CONSTRUCTORS(FFmpegAudioDecoder); 98 DISALLOW_IMPLICIT_CONSTRUCTORS(FFmpegAudioDecoder);
101 }; 99 };
102 100
103 } // namespace media 101 } // namespace media
104 102
105 #endif // MEDIA_FILTERS_FFMPEG_AUDIO_DECODER_H_ 103 #endif // MEDIA_FILTERS_FFMPEG_AUDIO_DECODER_H_
OLDNEW
« no previous file with comments | « media/filters/decrypting_video_decoder.cc ('k') | media/filters/ffmpeg_audio_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698