Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 11420060: Fix a crash in the compiler where an ssa instruction was using itself. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/bailout2_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (revision 15066)
+++ sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (working copy)
@@ -1118,11 +1118,13 @@
bool isJsStatement(HTypeMap types) => false;
bool dominates(HInstruction other) {
+ // An instruction does not dominates itself.
+ if (this == other) return false;
if (block != other.block) return block.dominates(other.block);
- HInstruction current = this;
+ HInstruction current = this.next;
while (current != null) {
- if (identical(current, other)) return true;
+ if (current == other) return true;
current = current.next;
}
return false;
« no previous file with comments | « no previous file | tests/language/bailout2_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698