Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp - Issue 11420033: Merge 134390 - Unable to set valid time value to input[type=time] with user interaction in some cas…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp

Issue 11420033: Merge 134390 - Unable to set valid time value to input[type=time] with user interaction in some cas… (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt ('k') | Source/WebCore/html/shadow/DateTimeEditElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp

===================================================================

--- Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp (revision 134891)

+++ Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp (working copy)

@@ -396,7 +396,7 @@

bool BaseMultipleFieldsDateAndTimeInputType::shouldHaveSecondField(const DateComponents& date) const

{

StepRange stepRange = createStepRange(AnyIsDefaultStep);

- return date.second()

+ return date.second() || date.millisecond()

|| !stepRange.minimum().remainder(static_cast<int>(msPerMinute)).isZero()

|| !stepRange.step().remainder(static_cast<int>(msPerMinute)).isZero();

}