Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1141993002: Inline binding_helpers.h (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline binding_helpers.h This code is inlined all over the place, however, there's no good location to put it. Just factoring it out in two places, however, doesn't really make sense, so don't do it R=mkwst@chromium.org BUG=478250 Committed: https://crrev.com/df8e8c6e3fa140af219a3c6440906baa7d84d620 Cr-Commit-Position: refs/heads/master@{#330308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -50 lines) Patch
D content/shell/renderer/binding_helpers.h View 1 chunk +0 lines, -42 lines 0 comments Download
M content/shell/renderer/ipc_echo.cc View 2 chunks +19 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 2 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-17 13:49:07 UTC) #1
jochen (gone - plz use gerrit)
2nd last before I'll add the DEPS file
5 years, 7 months ago (2015-05-17 13:49:29 UTC) #2
Mike West
Yeah, factoring it out doesn't make sense. LGTM.
5 years, 7 months ago (2015-05-17 14:04:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141993002/1
5 years, 7 months ago (2015-05-17 14:07:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-17 14:18:06 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:32:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df8e8c6e3fa140af219a3c6440906baa7d84d620
Cr-Commit-Position: refs/heads/master@{#330308}

Powered by Google App Engine
This is Rietveld 408576698