Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1141973002: Roll icu to 5788e2736b3bc6 from ce41627e388fb46 (Closed)

Created:
5 years, 7 months ago by jungshik at Google
Modified:
5 years, 7 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll icu to 5788e2736b3bc6 from ce41627e388fb46 Update tz db to 2015d Summary of changes available at: https://chromium.googlesource.com/chromium/deps/icu/+log/ce41627..5788e27 BUG=473288 TBR=jsbell@chromium.org TEST=In JS console, run the following to get 1:00 PM for 2015 instead of 2:00 PM. In 2014, it should return 2:00 PM. may_25_2015_1100 = new Date("05/25/2015 11:00Z") may_25_2015_1100.toLocaleString("en", {timeZone: "Africa/Cairo"}) may_25_2014_1100 = new Date("05/25/2014 11:00Z") may_25_2014_1100.toLocaleString("en", {timeZone: "Africa/Cairo"}) Committed: https://crrev.com/b5de2aaf9b38a09161f299037126d9f72f8dbb81 Cr-Commit-Position: refs/heads/master@{#330219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jungshik at Google
5 years, 7 months ago (2015-05-15 20:44:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141973002/1
5 years, 7 months ago (2015-05-15 20:45:40 UTC) #3
jsbell
lgtm
5 years, 7 months ago (2015-05-15 21:13:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 22:27:05 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:28:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5de2aaf9b38a09161f299037126d9f72f8dbb81
Cr-Commit-Position: refs/heads/master@{#330219}

Powered by Google App Engine
This is Rietveld 408576698