chrome/browser/extensions/api/storage/sync_storage_backend.h - Issue 1141963002: Remove a bunch of DeepCopy() calls in the chrome.storage API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/sync_storage_backend.h

Issue 1141963002: Remove a bunch of DeepCopy() calls in the chrome.storage API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/storage/settings_sync_unittest.cc ('k') | chrome/browser/extensions/api/storage/sync_storage_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/sync_storage_backend.h

diff --git a/chrome/browser/extensions/api/storage/sync_storage_backend.h b/chrome/browser/extensions/api/storage/sync_storage_backend.h

index 080fa8e7e3d9d9e8fcb27284f1ba91129909ea09..d5ca7f54fa8a698377dd62b09129a53a859ef043 100644

--- a/chrome/browser/extensions/api/storage/sync_storage_backend.h

+++ b/chrome/browser/extensions/api/storage/sync_storage_backend.h

@@ -67,7 +67,7 @@ class SyncStorageBackend : public syncer::SyncableService {

// initializing sync with some initial data if sync enabled.

SyncableSettingsStorage* GetOrCreateStorageWithSyncData(

const std::string& extension_id,

- const base::DictionaryValue& sync_data) const;

+ scoped_ptr<base::DictionaryValue> sync_data) const;

// Gets all extension IDs known to extension settings. This may not be all

// installed extensions.