Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: chrome/browser/extensions/api/storage/setting_sync_data.cc

Issue 1141963002: Remove a bunch of DeepCopy() calls in the chrome.storage API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/setting_sync_data.cc
diff --git a/chrome/browser/extensions/api/storage/setting_sync_data.cc b/chrome/browser/extensions/api/storage/setting_sync_data.cc
index 212f5c7abb1bd78d97cac81c2410b4d69c88fab9..a0f2d1bfc78621cc4649842815c5bd796213019b 100644
--- a/chrome/browser/extensions/api/storage/setting_sync_data.cc
+++ b/chrome/browser/extensions/api/storage/setting_sync_data.cc
@@ -82,9 +82,15 @@ const std::string& SettingSyncData::key() const {
}
const base::Value& SettingSyncData::value() const {
+ DCHECK(internal_.get()) << "value has been released";
Devlin 2015/05/15 21:59:07 Should these be DCHECKing internal_->value_?
not at google - send to devlin 2015/05/15 23:28:30 yes
return *internal_->value_;
}
+scoped_ptr<base::Value> SettingSyncData::PassValue() {
+ DCHECK(internal_.get()) << "value has been released";
+ return internal_->value_.Pass();
+}
+
SettingSyncData::Internal::Internal(
syncer::SyncChange::SyncChangeType change_type,
const std::string& extension_id,
@@ -94,7 +100,7 @@ SettingSyncData::Internal::Internal(
extension_id_(extension_id),
key_(key),
value_(value.Pass()) {
- DCHECK(value_.get());
+ DCHECK(value_.get()) << "value cannot be null";
}
SettingSyncData::Internal::~Internal() {}

Powered by Google App Engine
This is Rietveld 408576698