Chromium Code Reviews| Index: chrome/browser/extensions/api/storage/setting_sync_data.cc |
| diff --git a/chrome/browser/extensions/api/storage/setting_sync_data.cc b/chrome/browser/extensions/api/storage/setting_sync_data.cc |
| index 212f5c7abb1bd78d97cac81c2410b4d69c88fab9..a0f2d1bfc78621cc4649842815c5bd796213019b 100644 |
| --- a/chrome/browser/extensions/api/storage/setting_sync_data.cc |
| +++ b/chrome/browser/extensions/api/storage/setting_sync_data.cc |
| @@ -82,9 +82,15 @@ const std::string& SettingSyncData::key() const { |
| } |
| const base::Value& SettingSyncData::value() const { |
| + DCHECK(internal_.get()) << "value has been released"; |
|
Devlin
2015/05/15 21:59:07
Should these be DCHECKing internal_->value_?
not at google - send to devlin
2015/05/15 23:28:30
yes
|
| return *internal_->value_; |
| } |
| +scoped_ptr<base::Value> SettingSyncData::PassValue() { |
| + DCHECK(internal_.get()) << "value has been released"; |
| + return internal_->value_.Pass(); |
| +} |
| + |
| SettingSyncData::Internal::Internal( |
| syncer::SyncChange::SyncChangeType change_type, |
| const std::string& extension_id, |
| @@ -94,7 +100,7 @@ SettingSyncData::Internal::Internal( |
| extension_id_(extension_id), |
| key_(key), |
| value_(value.Pass()) { |
| - DCHECK(value_.get()); |
| + DCHECK(value_.get()) << "value cannot be null"; |
| } |
| SettingSyncData::Internal::~Internal() {} |